Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asf invalid notification scheme 'discussions_comment' #2250

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

Z-HUANT
Copy link
Contributor

@Z-HUANT Z-HUANT commented Jul 20, 2023

Purpose of the PR

need also remove discussions_comment for same problem:#2247

Main Changes

fix:asf invalid notification scheme 'discussions_comment'

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

fix:asf invalid notification scheme 'discussions_comment'

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #2250 (f4123fb) into master (c922b10) will increase coverage by 3.45%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2250      +/-   ##
============================================
+ Coverage     65.03%   68.49%   +3.45%     
  Complexity      977      977              
============================================
  Files           498      498              
  Lines         40684    40684              
  Branches       5681     5681              
============================================
+ Hits          26459    27865    +1406     
+ Misses        11601    10111    -1490     
- Partials       2624     2708      +84     

see 68 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin changed the title fix:asf invalid notification scheme 'discussions_comment' fix: asf invalid notification scheme 'discussions_comment' Jul 20, 2023
@imbajin imbajin merged commit 7927335 into apache:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants