Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dist): support pre-load test graph data in docker container #2241

Merged
merged 11 commits into from
Aug 28, 2023

Conversation

aroundabout
Copy link
Contributor

@aroundabout aroundabout commented Jul 11, 2023

Purpose of the PR

feature: pre-load some data in container(subtask of #840)

Main Changes

  1. Provide the related conf and groovy for user to pre load some data.
  2. Change the start-hugegraph.sh to get the environment variables to decide to pre-load or not.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified by github action

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (The docker hub should update, or the user should build the docker image themselves)

Documentation Status

The doc is still WIP.

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@imbajin imbajin changed the title feature: pre-load some data in container(#840) feat(dist): pre-load some data in docker container(#840) Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2241 (e948ea2) into master (8ee3d32) will increase coverage by 3.58%.
Report is 8 commits behind head on master.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2241      +/-   ##
============================================
+ Coverage     65.03%   68.62%   +3.58%     
  Complexity      979      979              
============================================
  Files           498      498              
  Lines         40682    41240     +558     
  Branches       5681     5738      +57     
============================================
+ Hits          26458    28299    +1841     
+ Misses        11596    10210    -1386     
- Partials       2628     2731     +103     

see 111 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hugegraph-dist/README.md Outdated Show resolved Hide resolved
javeme
javeme previously approved these changes Aug 3, 2023
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imbajin
imbajin previously approved these changes Aug 4, 2023
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after this PR merged, we should also update the doc in DockerHub page & website (doc repo) [TODO]

@imbajin imbajin changed the title feat(dist): pre-load some data in docker container(#840) feat(dist): support pre-load test graph data in docker container Aug 4, 2023
@aroundabout aroundabout requested a review from javeme August 8, 2023 04:55
coderzc
coderzc previously approved these changes Aug 9, 2023
@aroundabout aroundabout dismissed stale reviews from coderzc and imbajin via d18147b August 10, 2023 07:32
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and remember to add the related doc in website

s) OPEN_SECURITY_CHECK="$OPTARG" ;;
j) USER_OPTION="$OPTARG" ;;
t) SERVER_STARTUP_TIMEOUT_S="$OPTARG" ;;
# TODO: should remove it in future (check the usage carefully)
v) VERBOSE="verbose" ;;
?) echo "USAGE: $0 [-d true|false] [-g g1] [-m true|false] [-s true|false] [-j java_options]
?) echo "USAGE: $0 [-d true|false] [-g g1] [-m true|false] [-p true|false] [-s true|false] [-j java_options]
Copy link
Member

@imbajin imbajin Aug 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aroundabout update the doc in website (like quick-start section) to tell users (quick load with -p true when start server)

@imbajin imbajin merged commit 8a515f2 into apache:master Aug 28, 2023
@imbajin imbajin changed the title feat(dist): support pre-load test graph data in docker container feat(dist): support pre-load test graph data in docker container Aug 28, 2023
DanGuge pushed a commit to DanGuge/incubator-hugegraph that referenced this pull request Sep 25, 2023
…che#2241)

- Provide the related conf and groovy for user to pre load some data.
- Change the start-hugegraph.sh to get the environment variables to decide to pre-load or not.

---------

Co-authored-by: imbajin <[email protected]>
VGalaxies pushed a commit to VGalaxies/incubator-hugegraph that referenced this pull request Nov 10, 2023
…che#2241)

- Provide the related conf and groovy for user to pre load some data.
- Change the start-hugegraph.sh to get the environment variables to decide to pre-load or not.

---------

Co-authored-by: imbajin <[email protected]>
imbajin added a commit that referenced this pull request Nov 10, 2023
- Provide the related conf and groovy for user to pre load some data.
- Change the start-hugegraph.sh to get the environment variables to decide to pre-load or not.

---------

Co-authored-by: imbajin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

6 participants