-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dist): support pre-load test graph data in docker container #2241
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2241 +/- ##
============================================
+ Coverage 65.03% 68.62% +3.58%
Complexity 979 979
============================================
Files 498 498
Lines 40682 41240 +558
Branches 5681 5738 +57
============================================
+ Hits 26458 28299 +1841
+ Misses 11596 10210 -1386
- Partials 2628 2731 +103 see 111 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hugegraph-dist/src/assembly/static/scripts/example-preload.groovy
Outdated
Show resolved
Hide resolved
hugegraph-dist/src/assembly/static/conf/gremlin-server-preload.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after this PR merged, we should also update the doc in DockerHub page & website (doc repo) [TODO]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and remember to add the related doc in website
s) OPEN_SECURITY_CHECK="$OPTARG" ;; | ||
j) USER_OPTION="$OPTARG" ;; | ||
t) SERVER_STARTUP_TIMEOUT_S="$OPTARG" ;; | ||
# TODO: should remove it in future (check the usage carefully) | ||
v) VERBOSE="verbose" ;; | ||
?) echo "USAGE: $0 [-d true|false] [-g g1] [-m true|false] [-s true|false] [-j java_options] | ||
?) echo "USAGE: $0 [-d true|false] [-g g1] [-m true|false] [-p true|false] [-s true|false] [-j java_options] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aroundabout update the doc in website (like quick-start
section) to tell users (quick load with -p true
when start server)
…che#2241) - Provide the related conf and groovy for user to pre load some data. - Change the start-hugegraph.sh to get the environment variables to decide to pre-load or not. --------- Co-authored-by: imbajin <[email protected]>
…che#2241) - Provide the related conf and groovy for user to pre load some data. - Change the start-hugegraph.sh to get the environment variables to decide to pre-load or not. --------- Co-authored-by: imbajin <[email protected]>
- Provide the related conf and groovy for user to pre load some data. - Change the start-hugegraph.sh to get the environment variables to decide to pre-load or not. --------- Co-authored-by: imbajin <[email protected]>
Purpose of the PR
feature: pre-load some data in container(subtask of #840)
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
The doc is still WIP.
Doc - TODO
Doc - Done
Doc - No Need