-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: modify ASF and remove meaningless CLA #2237
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #2237 +/- ##
============================================
- Coverage 68.52% 64.39% -4.14%
+ Complexity 977 676 -301
============================================
Files 498 498
Lines 40682 40682
Branches 5681 5681
============================================
- Hits 27879 26197 -1682
- Misses 10097 11859 +1762
+ Partials 2706 2626 -80 see 79 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sync 3rd party doc section from website
I have submitted the newly added documents to my warehouse yesterday, why is the pr not updated here? |
|
try to submit an empty commit? |
should be ok |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1.Discussion is also split into discussion_status and discussion_comment, the former sends dev and the latter sends issues, so as to avoid the disturbance of a dev email for each comment and affect the effectiveness of everyone's subscription.
2.There is an obsolete and unnecessary CLA signature in our contribution doc, just remove it