Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(core): early stop unnecessary loops in edge cache #2211

Merged
merged 1 commit into from
May 16, 2023

Conversation

GYXkeep
Copy link
Contributor

@GYXkeep GYXkeep commented May 16, 2023

The loop in this method can jump out directly when the condition is met, avoiding useless loops.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #2211 (cbb7dd2) into master (267ff6d) will increase coverage by 3.55%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2211      +/-   ##
============================================
+ Coverage     61.53%   65.08%   +3.55%     
- Complexity      484      979     +495     
============================================
  Files           497      497              
  Lines         40572    40573       +1     
  Branches       5663     5663              
============================================
+ Hits          24965    26406    +1441     
+ Misses        13061    11553    -1508     
- Partials       2546     2614      +68     
Impacted Files Coverage Δ
...ugegraph/backend/cache/CachedGraphTransaction.java 80.52% <100.00%> (+0.10%) ⬆️

... and 27 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imbajin imbajin changed the title break out of unnecessary loops refact(core): break out of unnecessary loops in edge cache May 16, 2023
@imbajin imbajin changed the title refact(core): break out of unnecessary loops in edge cache refact(core): early stop unnecessary loops in edge cache May 16, 2023
@imbajin
Copy link
Member

imbajin commented May 16, 2023

Also mark the rocksdb raft test as a TODO problem, add it to the "help wanted tasks"

image

@imbajin imbajin merged commit f23c648 into apache:master May 16, 2023
@imbajin
Copy link
Member

imbajin commented May 16, 2023

TODO: Also another CI problem need to fix, refer link

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants