-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix snowflake license #2093
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2093 +/- ##
=========================================
Coverage 68.65% 68.65%
+ Complexity 979 977 -2
=========================================
Files 479 479
Lines 39655 39655
Branches 5578 5578
=========================================
Hits 27226 27226
Misses 9783 9783
Partials 2646 2646
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks, I'll check it with the official doc again |
hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zyxxoo we should also check other license header problem in the repo
keep this PR open & update it until all header problems done
LICENSE
Outdated
The following components are provided under the Apache License. See project link for details. | ||
The text of each license is the standard Apache 2.0 license. | ||
|
||
hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java files from https://github.com/twitter-archive/snowflake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "files"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need also add this license to release-docs/LICENSE
and release-doc/NOTICES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need also add this license to
release-docs/LICENSE
andrelease-doc/NOTICES
no NOTICE
in the original project, so only refer it in LICENSE
please check if we need address: #2093 (comment) |
subtask of #2095