Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix snowflake license #2093

Merged
merged 5 commits into from
Feb 9, 2023
Merged

Conversation

simon824
Copy link
Member

@simon824 simon824 commented Jan 17, 2023

subtask of #2095

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #2093 (85ca301) into master (eed6103) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2093   +/-   ##
=========================================
  Coverage     68.65%   68.65%           
+ Complexity      979      977    -2     
=========================================
  Files           479      479           
  Lines         39655    39655           
  Branches       5578     5578           
=========================================
  Hits          27226    27226           
  Misses         9783     9783           
  Partials       2646     2646           
Impacted Files Coverage Δ
...che/hugegraph/backend/id/SnowflakeIdGenerator.java 69.49% <ø> (ø)
...a/org/apache/hugegraph/task/ServerInfoManager.java 73.25% <0.00%> (-1.75%) ⬇️
...n/java/org/apache/hugegraph/schema/IndexLabel.java 76.13% <0.00%> (-1.14%) ⬇️
...g/apache/hugegraph/backend/store/BackendTable.java 84.52% <0.00%> (-0.60%) ⬇️
...a/org/apache/hugegraph/backend/cache/RamCache.java 73.48% <0.00%> (+0.55%) ⬆️
...ache/hugegraph/backend/store/hbase/HbaseTable.java 76.96% <0.00%> (+0.60%) ⬆️
...a/org/apache/hugegraph/util/collection/IntSet.java 75.00% <0.00%> (+1.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin
Copy link
Member

imbajin commented Jan 17, 2023

Thanks, I'll check it with the official doc again

javeme
javeme previously approved these changes Jan 17, 2023
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyxxoo we should also check other license header problem in the repo

keep this PR open & update it until all header problems done

LICENSE Outdated
The following components are provided under the Apache License. See project link for details.
The text of each license is the standard Apache 2.0 license.

hugegraph-core/src/main/java/org/apache/hugegraph/backend/id/SnowflakeIdGenerator.java files from https://github.com/twitter-archive/snowflake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "files"

Copy link
Contributor

@zyxxoo zyxxoo Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need also add this license to release-docs/LICENSE and release-doc/NOTICES

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need also add this license to release-docs/LICENSE and release-doc/NOTICES

no NOTICE in the original project, so only refer it in LICENSE

javeme
javeme previously approved these changes Feb 6, 2023
@javeme
Copy link
Contributor

javeme commented Feb 6, 2023

please check if we need address: #2093 (comment)

zyxxoo
zyxxoo previously approved these changes Feb 8, 2023
@simon824 simon824 dismissed stale reviews from zyxxoo and javeme via fc10b55 February 9, 2023 01:37
@imbajin imbajin merged commit effedb0 into apache:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants