Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary binary files & add rat check in ci #2086

Merged
merged 6 commits into from
Jan 14, 2023

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Jan 11, 2023

subtask of #1880
we're looking forward to a better way to import the swagger-ui instead of including the whole front-end dir (in dist)

currently, remove the extra license first

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #2086 (6dd1e93) into master (958193d) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2086      +/-   ##
============================================
+ Coverage     68.34%   68.37%   +0.03%     
+ Complexity      977      678     -299     
============================================
  Files           481      481              
  Lines         39831    39831              
  Branches       5602     5602              
============================================
+ Hits          27221    27233      +12     
+ Misses         9962     9953       -9     
+ Partials       2648     2645       -3     
Impacted Files Coverage Δ
...g/apache/hugegraph/backend/store/BackendTable.java 85.11% <0.00%> (+0.59%) ⬆️
...ugegraph/backend/cache/CachedGraphTransaction.java 86.77% <0.00%> (+1.05%) ⬆️
...hugegraph/backend/store/raft/rpc/RpcForwarder.java 71.18% <0.00%> (+1.69%) ⬆️
...a/org/apache/hugegraph/task/ServerInfoManager.java 75.00% <0.00%> (+1.74%) ⬆️
...egraph/backend/store/cassandra/CassandraShard.java 54.54% <0.00%> (+1.81%) ⬆️
...gegraph/election/RoleElectionStateMachineImpl.java 70.96% <0.00%> (+2.41%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin
Copy link
Member Author

imbajin commented Jan 12, 2023

@javeme useless jar?

image

image

if need it, move it to doc repo & download it

And another binary file:
image

@imbajin imbajin changed the title chore: remove extra license header in swagger-ui chore: remove extra license header in swagger-ui & remove binary files Jan 12, 2023
@imbajin imbajin changed the title chore: remove extra license header in swagger-ui & remove binary files chore: remove extra license header in swagger-ui & binary files Jan 12, 2023
@javeme
Copy link
Contributor

javeme commented Jan 13, 2023

rebase please

@imbajin
Copy link
Member Author

imbajin commented Jan 13, 2023

remove the changed files due to #2089 exclude them already (revert the commit)

@imbajin imbajin requested a review from zyxxoo January 13, 2023 16:44
@imbajin imbajin changed the title chore: remove extra license header in swagger-ui & binary files chore: remove unnecessary binary files Jan 13, 2023
@imbajin imbajin changed the title chore: remove unnecessary binary files chore: remove unnecessary binary files & add rat check in ci Jan 13, 2023
@imbajin
Copy link
Member Author

imbajin commented Jan 13, 2023

@javeme useless jar?

image image

if need it, move it to doc repo & download it

And another binary file: image

@zyxxoo consider handle the 4 archived/binary files in another PR

@imbajin imbajin added ci-cd Build or deploy apache labels Jan 13, 2023
@imbajin imbajin added this to the 1.0.0 milestone Jan 13, 2023
@imbajin imbajin merged commit f6018d1 into master Jan 14, 2023
@imbajin imbajin deleted the enhance-swagger branch January 14, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apache ci-cd Build or deploy
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants