Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check uncommit due to gremlin partition test silently fails #2065

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Jan 2, 2023

fix: #2058 (comment)
related: #2060

Change-Id: Icdecb9a2c4c3c9f3ee678f63a192e22093f3f9ff

Change-Id: Icdecb9a2c4c3c9f3ee678f63a192e22093f3f9ff
@codecov
Copy link

codecov bot commented Jan 2, 2023

Codecov Report

Merging #2065 (4463c5d) into master (93614cf) will increase coverage by 2.05%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##             master    #2065      +/-   ##
============================================
+ Coverage     66.31%   68.37%   +2.05%     
- Complexity      676      977     +301     
============================================
  Files           481      481              
  Lines         39823    39825       +2     
  Branches       5599     5601       +2     
============================================
+ Hits          26410    27231     +821     
+ Misses        10829     9950     -879     
- Partials       2584     2644      +60     
Impacted Files Coverage Δ
.../apache/hugegraph/backend/tx/GraphTransaction.java 79.81% <66.66%> (-0.06%) ⬇️
...va/org/apache/hugegraph/structure/HugeElement.java 71.04% <0.00%> (-2.27%) ⬇️
.../hugegraph/backend/store/rocksdb/RocksDBTable.java 67.11% <0.00%> (-2.02%) ⬇️
...hugegraph/backend/store/raft/rpc/RpcForwarder.java 69.49% <0.00%> (-1.70%) ⬇️
...ugegraph/backend/store/raft/StoreStateMachine.java 64.86% <0.00%> (-0.91%) ⬇️
...ava/org/apache/hugegraph/structure/HugeVertex.java 79.15% <0.00%> (-0.36%) ⬇️
...he/hugegraph/backend/tx/GraphIndexTransaction.java 83.66% <0.00%> (-0.11%) ⬇️
...hugegraph/backend/serializer/BinarySerializer.java 85.58% <0.00%> (+0.59%) ⬆️
...g/apache/hugegraph/backend/store/BackendTable.java 84.52% <0.00%> (+0.59%) ⬆️
...a/org/apache/hugegraph/util/collection/IntSet.java 75.00% <0.00%> (+1.27%) ⬆️
... and 12 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin
Copy link
Member

imbajin commented Jan 3, 2023

maybe release it in next version?

@zyxxoo zyxxoo merged commit 7efcf87 into master Jan 4, 2023
@zyxxoo zyxxoo deleted the partition-test-check branch January 4, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] TinkerPop unit test bug
3 participants