-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: empty label exception should be labelCanNotBeNull() #2063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption when label is null
Codecov Report
@@ Coverage Diff @@
## master #2063 +/- ##
============================================
- Coverage 68.35% 68.34% -0.01%
Complexity 977 977
============================================
Files 481 481
Lines 39821 39823 +2
Branches 5598 5599 +1
============================================
Hits 27219 27219
- Misses 9957 9959 +2
Partials 2645 2645
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
reviewed
Dec 29, 2022
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeElement.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeElement.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Dec 29, 2022
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeElement.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/org/apache/hugegraph/structure/HugeElement.java
Outdated
Show resolved
Hide resolved
ci error Error: Failures:
Error: AuthTest.testDeleteBelong:867 Bad exception type java.lang.IllegalStateException(expected java.lang.IllegalArgumentException)
Error: AuthTest.testGetBelong:795 Bad exception type java.lang.IllegalStateException(expected java.lang.IllegalArgumentException)
Error: VertexCoreTest.testAddVertexWithPrimaryValuesEmpty:841 Bad exception type java.lang.IllegalStateException(expected java.lang.IllegalArgumentException)
Error: Errors:
Error: EdgeCoreTest.testQueryEdgeByPropertyWithEmptyString:6931 » IllegalState The pr...
Error: VertexCoreTest.testAddVerticesWithUniqueIndexForNullableProperties:5946 » IllegalState
Error: VertexCoreTest.testQueryVertexByPropertyWithEmptyString:6438 » IllegalState Th...
[INFO]
Error: Tests run: 731, Failures: 3, Errors: 3, Skipped: 81 |
imbajin
changed the title
Fix TinkerPop unit test: label null throw exception should be labelCanNotBeNull() #2058
fix: empty label exception should be labelCanNotBeNull()
Dec 29, 2022
imbajin
reviewed
Dec 29, 2022
imbajin
reviewed
Dec 29, 2022
imbajin
approved these changes
Dec 30, 2022
coderzc
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix sub-issue 8 #2058