Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specify the code generation directory for raft.proto #2057

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

simon824
Copy link
Member

@simon824 simon824 commented Dec 19, 2022

followup #2045 , without specifying the code generation directory for raft.proto
image

@simon824
Copy link
Member Author

@zyxxoo PTAL ,thanks

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #2057 (cc735c9) into master (8047fe7) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2057      +/-   ##
============================================
- Coverage     68.47%   68.41%   -0.06%     
- Complexity      679      978     +299     
============================================
  Files           481      481              
  Lines         39749    39749              
  Branches       5582     5582              
============================================
- Hits          27217    27195      -22     
- Misses         9908     9928      +20     
- Partials       2624     2626       +2     
Impacted Files Coverage Δ
...ackend/store/cassandra/CassandraEntryIterator.java 73.91% <0.00%> (-10.15%) ⬇️
...e/hugegraph/backend/tx/SchemaIndexTransaction.java 72.72% <0.00%> (-6.82%) ⬇️
.../apache/hugegraph/backend/store/raft/RaftNode.java 58.33% <0.00%> (-5.13%) ⬇️
.../hugegraph/backend/store/BackendEntryIterator.java 61.53% <0.00%> (-2.57%) ⬇️
...graph/backend/store/cassandra/CassandraTables.java 89.83% <0.00%> (-0.70%) ⬇️
...a/org/apache/hugegraph/backend/cache/RamCache.java 72.92% <0.00%> (-0.56%) ⬇️
...a/org/apache/hugegraph/util/collection/IntMap.java 72.40% <0.00%> (-0.40%) ⬇️
...a/org/apache/hugegraph/util/collection/IntSet.java 75.00% <0.00%> (+1.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin merged commit fc27f2c into apache:master Dec 21, 2022
javeme pushed a commit that referenced this pull request Dec 26, 2022
* chore: don't support persistence for memory backend
* chore: setup graph by first step graph when graph is null
* chore: apply relations optimize logic
* chore: don't support null properties
* fix: g.V().has(empty).count() and g.V().count().as('a').select('a')
* fix: specify the code generation directory for raft.proto (#2057)
* fix: tinkerpop unit schema no define
* fix the style & clean some outdated code

Co-authored-by: Simon Cheung <[email protected]>
Co-authored-by: imbajin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants