Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): update Dockerfile & add image-building script #2046

Closed
wants to merge 6 commits into from

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Dec 5, 2022

subtask of #840

@codecov

This comment was marked as off-topic.

@coderzc coderzc marked this pull request as draft December 5, 2022 07:29
@coderzc coderzc requested a review from imbajin December 5, 2022 12:03

# 3. Init HugeGraph Hubble
RUN set -e \
&& cd /hugegraph/hugegraph-server/hugegraph-hubble \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the hubble? it's in toolchain repo now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: #2046 (files)

who call it? (or just leave for future hubble download URI?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see: #2046 (files)

who call it? (or just leave for future hubble download URI?)

just leave for future hubble download URI

@imbajin imbajin changed the title Add build image shell chore(docker): update Dockerfile & add image-building script Dec 6, 2022
-Dexec.executable='echo' -Dexec.args='${final.name}')
CONTEXT_PATH="${PROJECT_PATH}/${CONTEXT_PATH}"

if [ -n "$2" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we define a var for $2 for more readable

@imbajin imbajin mentioned this pull request Dec 15, 2022
15 tasks
@github-actions

This comment was marked as outdated.

@javeme
Copy link
Contributor

javeme commented Jan 15, 2023

@coderzc ready for review?

-Dexec.executable='echo' -Dexec.args='${final.name}')
CONTEXT_PATH="${PROJECT_PATH}/${CONTEXT_PATH}"

if [ -n "$2" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we define a var WITH_HUBBLE=$2 for more readable

@github-actions

This comment was marked as duplicate.

@imbajin imbajin added improvement General improvement help wanted Extra attention is needed ci-cd Build or deploy and removed inactive labels Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy help wanted Extra attention is needed improvement General improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Support build docker image from Dockerfile (Task Summary)
5 participants