-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): update Dockerfile & add image-building script #2046
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
|
||
# 3. Init HugeGraph Hubble | ||
RUN set -e \ | ||
&& cd /hugegraph/hugegraph-server/hugegraph-hubble \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is the hubble? it's in toolchain repo now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see: #2046 (files)
who call it? (or just leave for future hubble download URI?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see: #2046 (files)
who call it? (or just leave for future hubble download URI?)
just leave for future hubble download URI
-Dexec.executable='echo' -Dexec.args='${final.name}') | ||
CONTEXT_PATH="${PROJECT_PATH}/${CONTEXT_PATH}" | ||
|
||
if [ -n "$2" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we define a var for $2 for more readable
This comment was marked as outdated.
This comment was marked as outdated.
@coderzc ready for review? |
-Dexec.executable='echo' -Dexec.args='${final.name}') | ||
CONTEXT_PATH="${PROJECT_PATH}/${CONTEXT_PATH}" | ||
|
||
if [ -n "$2" ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we define a var WITH_HUBBLE=$2 for more readable
subtask of #840