refact: adapt apache package and dependency in all modules (Breaking Change) #2019

z7658329 · 2022-11-18T08:20:03Z

implement #1985

z7658329 · 2022-11-18T08:22:36Z

also need to rebuild license? @simon824

codecov · 2022-11-18T09:02:13Z

Codecov Report

Merging #2019 (22c4012) into master (44bea37) will increase coverage by 0.07%.
The diff coverage is 55.96%.

❗ Current head 22c4012 differs from pull request most recent head 64e7357. Consider uploading reports for the commit 64e7357 to get more accurate results

@@             Coverage Diff              @@
##             master    #2019      +/-   ##
============================================
+ Coverage     66.32%   66.39%   +0.07%     
  Complexity      976      976              
============================================
  Files           482      482              
  Lines         41463    41455       -8     
  Branches       5890     5888       -2     
============================================
+ Hits          27500    27526      +26     
+ Misses        11263    11232      -31     
+ Partials       2700     2697       -3

Impacted Files	Coverage Δ
...pi/src/main/java/org/apache/hugegraph/api/API.java	`74.11% <ø> (ø)`
.../java/org/apache/hugegraph/api/auth/AccessAPI.java	`0.00% <ø> (ø)`
.../java/org/apache/hugegraph/api/auth/BelongAPI.java	`0.00% <ø> (ø)`
...n/java/org/apache/hugegraph/api/auth/GroupAPI.java	`0.00% <ø> (ø)`
...n/java/org/apache/hugegraph/api/auth/LoginAPI.java	`74.28% <ø> (ø)`
...java/org/apache/hugegraph/api/auth/ProjectAPI.java	`82.05% <ø> (ø)`
.../java/org/apache/hugegraph/api/auth/TargetAPI.java	`0.00% <ø> (ø)`
...in/java/org/apache/hugegraph/api/auth/UserAPI.java	`75.80% <ø> (ø)`
...che/hugegraph/api/filter/AuthenticationFilter.java	`55.00% <ø> (ø)`
...ache/hugegraph/api/filter/CompressInterceptor.java	`73.07% <ø> (ø)`
... and 690 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

hugegraph-core/src/main/java/org/apache/hugegraph/util/ConfigUtil.java

javeme · 2022-11-19T03:33:46Z

@z7658329 can we move the CodeQL fixes into a separate PR?

z7658329 · 2022-11-19T04:08:15Z

@z7658329 can we move the CodeQL fixes into a separate PR?

i have fixed, but in ci progress ,
hugegraph-ci / build (rocksdb, 11) (pull_request) failed, should rerun it , @javeme @imbajin see :

hugegraph-api/src/main/java/org/apache/hugegraph/api/auth/BelongAPI.java

hugegraph-api/src/main/java/org/apache/hugegraph/api/auth/GroupAPI.java

hugegraph-api/src/main/java/org/apache/hugegraph/api/graph/VertexAPI.java

hugegraph-api/src/main/java/org/apache/hugegraph/api/job/AlgorithmAPI.java

hugegraph-api/src/main/java/org/apache/hugegraph/api/graph/EdgeAPI.java

hugegraph-core/src/main/java/org/apache/hugegraph/HugeGraph.java

hugegraph-core/src/main/java/org/apache/hugegraph/auth/ResourceObject.java

imbajin · 2022-11-22T10:45:06Z

some TODOs & Warning:

the APIVersion now is 0.67, shall we keep it?
CommonVersion

@javeme why we need check common's version?

javeme · 2022-11-22T12:41:11Z

the APIVersion now is 0.67, shall we keep it?
- yes we need to keep it, api version must increase forever.
why check common's version?
- to avoid importing two different common jars with conflict versions.

imbajin · 2022-11-22T13:02:19Z

why check common's version?
: to avoid importing two different common jars with conflict versions.

What does this mean? At present, the whole project seems to have only one huge-common dependency

javeme · 2022-11-22T13:38:02Z

What does this mean? At present, the whole project seems to have only one huge-common dependency

someone may import hg as a lib, at the same time also has imported hg-common.

imbajin · 2022-11-22T13:51:30Z

What does this mean? At present, the whole project seems to have only one huge-common dependency

someone may import hg as a lib, at the same time also has imported hg-common.

Seems it should be handled by users(like use a fixed version or exclude the duplicate one), and currently it have 2 problems:

the check fails when the version is 1.0.0 but the range is 2.x~2.x
how to set the new version? (because the old common also use the 1.x & 2.x as their version num)

consider handle this in a separate PR

javeme · 2022-11-22T14:40:26Z

pom.xml

@@ -130,16 +82,16 @@

    <dependencyManagement>
        <dependencies>
-            <!-- hugegraph-commons -->
+            <!-- TODO: could we merge them to hugegraph-commons only? -->


no we can't merge them, because in some scenarios it is not necessary to import both the two packages at the same time, like client or loader.

OK, change the comment in next PR (could modify the common version together @z7658329 )

z7658329 · 2022-11-22T15:11:37Z

What does this mean? At present, the whole project seems to have only one huge-common dependency

someone may import hg as a lib, at the same time also has imported hg-common.

Seems it should be handled by users(like use a fixed version or exclude the duplicate one), and currently it have 2 problems:

the check fails when the version is 1.0.0 but the range is 2.x~2.x

how to set the new version? (because the old common also use the 1.x & 2.x as their version num)

consider handle this in a separate PR

z7658329 · 2022-11-22T15:13:17Z

What does this mean? At present, the whole project seems to have only one huge-common dependency

someone may import hg as a lib, at the same time also has imported hg-common.

Seems it should be handled by users(like use a fixed version or exclude the duplicate one), and currently it have 2 problems:

the check fails when the version is 1.0.0 but the range is 2.x~2.x

how to set the new version? (because the old common also use the 1.x & 2.x as their version num)

consider handle this in a separate PR

so the VersionTest.testCoreVersionCheck successed! we need update commons jar? @javeme @imbajin

in dubbo project, use like this:

see : apache/incubator-hugegraph-commons#119

TODO: and we need also check the 0.69 in pom

imbajin

use rebase and merge

imbajin requested review from javeme, imbajin and coderzc November 18, 2022 11:46

javeme previously approved these changes Nov 18, 2022

View reviewed changes

z7658329 dismissed javeme’s stale review via 27c0886 November 18, 2022 14:06

javeme previously approved these changes Nov 18, 2022

View reviewed changes

z7658329 dismissed javeme’s stale review via 22d43cb November 18, 2022 14:47

imbajin reviewed Nov 18, 2022

View reviewed changes

hugegraph-core/src/main/java/org/apache/hugegraph/util/ConfigUtil.java Outdated Show resolved Hide resolved

imbajin mentioned this pull request Nov 18, 2022

[Summary] Server Release v1.0 TODOs #2011

Closed

15 tasks

javeme reviewed Nov 19, 2022

View reviewed changes

javeme previously approved these changes Nov 20, 2022

View reviewed changes

z7658329 dismissed javeme’s stale review via c4b951c November 20, 2022 13:39

javeme reviewed Nov 20, 2022

View reviewed changes

hugegraph-api/src/main/java/org/apache/hugegraph/api/job/AlgorithmAPI.java Outdated Show resolved Hide resolved

hugegraph-api/src/main/java/org/apache/hugegraph/api/graph/EdgeAPI.java Outdated Show resolved Hide resolved

javeme previously approved these changes Nov 20, 2022

View reviewed changes

z7658329 dismissed javeme’s stale review via 36f6e76 November 21, 2022 06:42

imbajin reviewed Nov 21, 2022

View reviewed changes

hugegraph-core/src/main/java/org/apache/hugegraph/HugeGraph.java Outdated Show resolved Hide resolved

hugegraph-core/src/main/java/org/apache/hugegraph/auth/ResourceObject.java Outdated Show resolved Hide resolved

imbajin changed the title ~~adapt apache package and dependency~~ refact: adapt apache package and dependency in all modules (Breaking Change) Nov 22, 2022

imbajin previously approved these changes Nov 22, 2022

View reviewed changes

javeme previously approved these changes Nov 22, 2022

View reviewed changes

z7658329 closed this Nov 22, 2022

z7658329 reopened this Nov 22, 2022

imbajin dismissed stale reviews from javeme and themself via f1db302 November 23, 2022 03:28

imbajin force-pushed the feat/package_to_apache branch from c2dfb03 to f1db302 Compare November 23, 2022 03:28

z7658329 and others added 2 commits November 23, 2022 11:39

refact: adapt all to apache package and dependencies (Breaking Changes)

83fa9d5

refact(cassandra): update pom & ApiVersion & fix style

64e7357

TODO: and we need also check the 0.69 in pom

imbajin force-pushed the feat/package_to_apache branch from 22c4012 to 64e7357 Compare November 23, 2022 03:42

imbajin approved these changes Nov 23, 2022

View reviewed changes

javeme approved these changes Nov 23, 2022

View reviewed changes

javeme merged commit d340420 into apache:master Nov 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refact: adapt apache package and dependency in all modules (Breaking Change) #2019

refact: adapt apache package and dependency in all modules (Breaking Change) #2019

z7658329 commented Nov 18, 2022 •

edited by javeme

Loading

z7658329 commented Nov 18, 2022 •

edited

Loading

codecov bot commented Nov 18, 2022 •

edited

Loading

javeme commented Nov 19, 2022

z7658329 commented Nov 19, 2022 •

edited

Loading

imbajin commented Nov 22, 2022 •

edited

Loading

javeme commented Nov 22, 2022

imbajin commented Nov 22, 2022

javeme commented Nov 22, 2022

imbajin commented Nov 22, 2022 •

edited

Loading

javeme Nov 22, 2022

imbajin Nov 22, 2022

z7658329 commented Nov 22, 2022

z7658329 commented Nov 22, 2022 •

edited

Loading

imbajin left a comment

refact: adapt apache package and dependency in all modules (Breaking Change) #2019

refact: adapt apache package and dependency in all modules (Breaking Change) #2019

Conversation

z7658329 commented Nov 18, 2022 • edited by javeme Loading

z7658329 commented Nov 18, 2022 • edited Loading

codecov bot commented Nov 18, 2022 • edited Loading

Codecov Report

javeme commented Nov 19, 2022

z7658329 commented Nov 19, 2022 • edited Loading

imbajin commented Nov 22, 2022 • edited Loading

javeme commented Nov 22, 2022

imbajin commented Nov 22, 2022

javeme commented Nov 22, 2022

imbajin commented Nov 22, 2022 • edited Loading

javeme Nov 22, 2022

Choose a reason for hiding this comment

imbajin Nov 22, 2022

Choose a reason for hiding this comment

z7658329 commented Nov 22, 2022

z7658329 commented Nov 22, 2022 • edited Loading

imbajin left a comment

Choose a reason for hiding this comment

z7658329 commented Nov 18, 2022 •

edited by javeme

Loading

z7658329 commented Nov 18, 2022 •

edited

Loading

codecov bot commented Nov 18, 2022 •

edited

Loading

z7658329 commented Nov 19, 2022 •

edited

Loading

imbajin commented Nov 22, 2022 •

edited

Loading

imbajin commented Nov 22, 2022 •

edited

Loading

z7658329 commented Nov 22, 2022 •

edited

Loading