-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug: Closing iterators on errors for CassandraTable and MysqlTable #2014
Fix bug: Closing iterators on errors for CassandraTable and MysqlTable #2014
Conversation
hi @javeme . Plz review. I noticed a similar issue for MysqlTable so added that as well as part of the PR |
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
==========================================
Coverage 66.35% 66.36%
- Complexity 677 978 +301
==========================================
Files 482 482
Lines 41449 41457 +8
Branches 5890 5890
==========================================
+ Hits 27505 27512 +7
- Misses 11244 11248 +4
+ Partials 2700 2697 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution
...raph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraTable.java
Outdated
Show resolved
Hide resolved
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlTable.java
Outdated
Show resolved
Hide resolved
...raph-cassandra/src/main/java/com/baidu/hugegraph/backend/store/cassandra/CassandraTable.java
Outdated
Show resolved
Hide resolved
Thanks @javeme . I made the changes. |
Fix #1983