Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Closing iterators on errors for CassandraTable and MysqlTable #2014

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

vamossagar12
Copy link
Contributor

Fix #1983

@vamossagar12
Copy link
Contributor Author

hi @javeme . Plz review. I noticed a similar issue for MysqlTable so added that as well as part of the PR

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #2014 (6f9acd3) into master (020b7dc) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             master    #2014    +/-   ##
==========================================
  Coverage     66.35%   66.36%            
- Complexity      677      978   +301     
==========================================
  Files           482      482            
  Lines         41449    41457     +8     
  Branches       5890     5890            
==========================================
+ Hits          27505    27512     +7     
- Misses        11244    11248     +4     
+ Partials       2700     2697     -3     
Impacted Files Coverage Δ
...egraph/backend/store/cassandra/CassandraTable.java 79.05% <0.00%> (-1.09%) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 82.66% <0.00%> (-0.80%) ⬇️
...va/com/baidu/hugegraph/util/collection/IntMap.java 72.80% <0.00%> (+0.39%) ⬆️
...va/com/baidu/hugegraph/backend/cache/RamCache.java 73.48% <0.00%> (+0.55%) ⬆️
...om/baidu/hugegraph/backend/store/BackendTable.java 85.11% <0.00%> (+0.59%) ⬆️
...in/java/com/baidu/hugegraph/schema/IndexLabel.java 77.27% <0.00%> (+1.13%) ⬆️
...va/com/baidu/hugegraph/task/ServerInfoManager.java 75.00% <0.00%> (+1.74%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@vamossagar12
Copy link
Contributor Author

Thanks for your contribution

Thanks @javeme . I made the changes.

@javeme javeme merged commit 833ce2f into apache:master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] should close ExtendableIterator when cassandra exception
3 participants