-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(apache): add apache license checker for CI #2009
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2009 +/- ##
============================================
+ Coverage 62.38% 63.96% +1.57%
+ Complexity 978 675 -303
============================================
Files 482 482
Lines 41463 41463
Branches 5890 5890
============================================
+ Hits 25868 26523 +655
+ Misses 13047 12299 -748
- Partials 2548 2641 +93
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
thanks for your contribution wonder to know the differ with our current CI (like in toolchain @simon824 ) ,it use mvn mat:check to check the license. and we don't need to add license header in github's file because they won't be packaged into source file. (refer pom.xml in root) |
Thanks for your reply. I am sorry, I don't understand the This PR yes, we can ignore |
like this pr in toolchain(repo) apache/incubator-hugegraph-toolchain#352 it also check the license in CI |
OK, I known, thanks.
But the common scenes is check file license. we have these capability, I will close these this PR, thanks. Do we have some communication tool, like wechat group? |
seems it's nice if it could add the license automatically @JackyYangPassion could u try or compare it? and we do have the wechat group, I have send u a email including the ID already~ |
hi @dongzl , |
Hi @simon824, It can add license header in batches when the source files doesn't have license header. |
Thanks, email is |
close by #2034 |
No description provided.