fix: User-controlled data in numeric cast [#1987] #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1996 +/- ##
============================================
- Coverage 70.59% 70.50% -0.09%
- Complexity 976 978 +2
============================================
Files 454 454
Lines 39050 39051 +1
Branches 5557 5557
============================================
- Hits 27568 27534 -34
- Misses 8785 8818 +33
- Partials 2697 2699 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
javeme
reviewed
Oct 30, 2022
hugegraph-core/src/protobuf/java/com/baidu/hugegraph/backend/store/raft/rpc/RaftRequests.java
Outdated
Show resolved
Hide resolved
| @@ -67,7 +67,7 @@ public String get(@Context GraphManager manager, | |||
| @QueryParam("max_degree") | |||
| @DefaultValue(DEFAULT_MAX_DEGREE) long maxDegree, | |||
| @QueryParam("limit") | |||
| @DefaultValue(DEFAULT_ELEMENTS_LIMIT) long limit) { | |||
| @DefaultValue(DEFAULT_ELEMENTS_LIMIT) int limit) { | |||
There was a problem hiding this comment.
do all the algorithms(like adamicAdar) need to param limit with type int?
There was a problem hiding this comment.
Ok, I change the other algorithms limit type to int
There was a problem hiding this comment.
These place long are not suitable, because the java package only support int type on collections
There was a problem hiding this comment.
I have change all algorithms limit type long to int, and I have put a pr for hugegraph-client
javeme
reviewed
Oct 30, 2022
| @@ -149,7 +153,7 @@ public void master(StateMachineContext context) { | |||
| if (logRecords.size() > MAX_COUNT) { | |||
| context.stateMachine().shutdown(); | |||
| } | |||
| System.out.println("master node: " + node); | |||
| LOG.info("master node: " + node); | |||
There was a problem hiding this comment.
prefer to define a UtilXx.print() method
javeme
approved these changes
Oct 30, 2022
imbajin
approved these changes
Oct 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.