-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refact: modify abnormal logs #1948
Conversation
@@ -59,7 +59,7 @@ | |||
@Tag(name = "AccessAPI") | |||
public class AccessAPI extends API { | |||
|
|||
private static final Logger LOG = Log.logger(RestServer.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RestServer 相关是有一定原因和考虑意义的, 另外它可以全局调整 rest-api 的所有日志级别.
这个改不改可以看看其他同学意见
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块我能理解,但是看已有代码也不够统一
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这块我能理解,但是看已有代码也不够统一
嗯嗯后面有些修正是需要的 ✓ (那种一般是更新类名的时候没注意一起调整)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RestServer 相关是有一定原因和考虑意义的, 另外它可以全局调整 rest-api 的所有日志级别.
这个改不改可以看看其他同学意见
好像可以根据包路径配置日志的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RestServer 相关是有一定原因和考虑意义的, 另外它可以全局调整 rest-api 的所有日志级别.
这个改不改可以看看其他同学意见好像可以根据包路径配置日志的
是可以, 当然我指的是运行时动态调整日志级别 (不过那个也可以单独修改)
这里复用一个类名是不是有什么其他历史考量呢, 需要确认一下 @javeme
682ea82
to
bcb7bb4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1948 +/- ##
============================================
+ Coverage 70.47% 70.50% +0.03%
Complexity 724 724
============================================
Files 452 452
Lines 38984 38990 +6
Branches 5554 5554
============================================
+ Hits 27473 27490 +17
+ Misses 8814 8805 -9
+ Partials 2697 2695 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -45,7 +45,7 @@ | |||
|
|||
public class API { | |||
|
|||
protected static final Logger LOG = Log.logger(RestServer.class); | |||
protected static final Logger LOG = Log.logger(API.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it would be nice if the log-framework could support a unified approach like this (I don't know if there is a way) :
Logger LOG = Log.logger(this);
bcb7bb4
to
9076d77
Compare
9076d77
to
d7afcbb
Compare
fix #1947