Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix redundant Checkstyle #1896

Merged
merged 21 commits into from
Oct 30, 2022
Merged

fix redundant Checkstyle #1896

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
163df9f
add redundant
seagle-yuan Jun 3, 2022
db21536
Merge branch 'master' into checkstyle-redundant
seagle-yuan Jun 5, 2022
02f0207
add redundant check
seagle-yuan Jun 5, 2022
bfdf11a
merge line
seagle-yuan Jun 5, 2022
12b91c1
update alignment
seagle-yuan Jun 6, 2022
2de645d
Merge branch 'master' into checkstyle-redundant
seagle-yuan Jun 13, 2022
92a4bf0
delete duplicates check MissingSwitchDefault
seagle-yuan Jun 15, 2022
f437554
Merge branch 'apache:master' into checkstyle-redundant
seagle-yuan Jun 15, 2022
f6240a5
Merge branch 'checkstyle-redundant' of https://github.com/seagle-yuan…
seagle-yuan Jun 15, 2022
d3d7c79
update wrap line
seagle-yuan Jun 15, 2022
ff82af0
update code style
seagle-yuan Jun 17, 2022
432cc04
Merge branch 'master' into checkstyle-redundant
seagle-yuan Jul 6, 2022
74193f2
Merge branch 'apache:master' into checkstyle-redundant
seagle-yuan Jul 6, 2022
f96a617
Merge branch 'checkstyle-redundant' of https://github.com/seagle-yuan…
seagle-yuan Jul 6, 2022
765bd85
Merge branch 'apache:master' into checkstyle-redundant
seagle-yuan Aug 3, 2022
1447e1e
Merge branch 'master' into checkstyle-redundant
seagle-yuan Aug 3, 2022
341a18a
Merge branch 'checkstyle-redundant' of https://github.com/seagle-yuan…
seagle-yuan Sep 9, 2022
c1e2d4c
merge dev
seagle-yuan Oct 12, 2022
6ab5ab6
merge master
seagle-yuan Oct 12, 2022
8cda2a0
merge master
seagle-yuan Oct 12, 2022
868ee2f
Merge branch 'apache:master' into checkstyle-redundant
seagle-yuan Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions hugegraph-api/src/main/java/com/baidu/hugegraph/auth/HugeAuthenticator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,8 @@

public interface HugeAuthenticator extends Authenticator {

String KEY_USERNAME =
CredentialGraphTokens.PROPERTY_USERNAME;
String KEY_PASSWORD =
CredentialGraphTokens.PROPERTY_PASSWORD;
String KEY_USERNAME = CredentialGraphTokens.PROPERTY_USERNAME;
String KEY_PASSWORD = CredentialGraphTokens.PROPERTY_PASSWORD;
String KEY_TOKEN = "token";
String KEY_ROLE = "role";
String KEY_ADDRESS = "address";
Expand All @@ -66,8 +64,7 @@ public interface HugeAuthenticator extends Authenticator {

void setup(HugeConfig config);

UserWithRole authenticate(String username, String password,
String token);
UserWithRole authenticate(String username, String password, String token);

AuthManager authManager();

Expand Down
12 changes: 4 additions & 8 deletions hugegraph-api/src/main/java/com/baidu/hugegraph/serializer/Serializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ public interface Serializer {

String writeAuthElement(AuthElement elem);

<V extends AuthElement> String writeAuthElements(String label,
List<V> users);
<V extends AuthElement> String writeAuthElements(String label, List<V> users);

String writePaths(String name, Collection<HugeTraverser.Path> paths,
seagle-yuan marked this conversation as resolved.
Show resolved Hide resolved
boolean withCrossPoint, Iterator<Vertex> vertices);
Expand All @@ -91,14 +90,11 @@ default String writePaths(String name,
String writeCrosspoints(CrosspointsPaths paths,
Iterator<Vertex> iterator, boolean withPath);

String writeSimilars(SimilarsMap similars,
Iterator<Vertex> vertices);
String writeSimilars(SimilarsMap similars, Iterator<Vertex> vertices);

String writeWeightedPath(NodeWithWeight path,
Iterator<Vertex> vertices);
String writeWeightedPath(NodeWithWeight path, Iterator<Vertex> vertices);

String writeWeightedPaths(WeightedPaths paths,
Iterator<Vertex> vertices);
String writeWeightedPaths(WeightedPaths paths, Iterator<Vertex> vertices);

String writeNodesWithPath(String name, List<Id> nodes, long size,
Collection<HugeTraverser.Path> paths,
Expand Down
2 changes: 1 addition & 1 deletion hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/Aggregate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ public enum AggregateFunc {
private final BiFunction<Number, Number, Number> merger;

AggregateFunc(String name, Number defaultValue,
seagle-yuan marked this conversation as resolved.
Show resolved Hide resolved
BiFunction<Number, Number, Number> merger) {
BiFunction<Number, Number, Number> merger) {
this.name = name;
this.defaultValue = defaultValue;
this.merger = merger;
Expand Down
2 changes: 0 additions & 2 deletions hugegraph-core/src/main/java/com/baidu/hugegraph/util/RateLimiter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@
// TODO: Move to common module (concurrent package)
public interface RateLimiter {

Logger LOG = Log.logger(RateLimiter.class);

long RESET_PERIOD = 1000L;

/**
Expand Down
3 changes: 1 addition & 2 deletions hugegraph-hbase/src/main/java/com/baidu/hugegraph/backend/store/hbase/HbaseSessions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,7 @@ public interface HbaseSession<R> {
/**
* Add a row record to a table
*/
void put(String table, byte[] family, byte[] rowkey,
Collection<BackendColumn> columns);
void put(String table, byte[] family, byte[] rowkey, Collection<BackendColumn> columns);
seagle-yuan marked this conversation as resolved.
Show resolved Hide resolved

/**
* Add a row record to a table(can be used when adding an index)
Expand Down