Check exist same Id when inserting vertices with customized id strategy #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
previously requested changes
Nov 13, 2018
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
Linary
force-pushed
the
check-vertex-exist
branch
from
88ca656 to
0a4449b
Compare
javeme
requested changes
Nov 14, 2018
|
|
||
| public static final ConfigOption<Boolean> CHECK_CUSTOMIZED_ID_VERTEX = | ||
| new ConfigOption<>( | ||
| "check_customzied_id_vertex", |
There was a problem hiding this comment.
vertex.check_customzied_id_exist
| @@ -207,6 +207,10 @@ protected BackendMutation prepareCommit() { | |||
|
|
|||
| protected void prepareAdditions(Map<Id, HugeVertex> addedVertexes, | |||
| Map<Id, HugeEdge> addedEdges) { | |||
| HugeConfig config = this.graph().configuration(); | |||
| if (config.get(CoreOptions.CHECK_CUSTOMIZED_ID_VERTEX)) { | |||
There was a problem hiding this comment.
prefer to add a private field for it
Linary
force-pushed
the
check-vertex-exist
branch
from
0a4449b to
a03f5d1
Compare
javeme
previously requested changes
Nov 15, 2018
| @@ -113,6 +115,8 @@ public GraphTransaction(HugeGraph graph, BackendStore store) { | |||
| assert !this.indexTx.autoCommit(); | |||
|
|
|||
| final HugeConfig conf = graph.configuration(); | |||
| this.checkIdExist = conf.get( | |||
| CoreOptions.VERTEX_CHECK_CUSTOMIZED_ID_EXIST); | |||
There was a problem hiding this comment.
rename to:
this.checkVertexId = conf.get(CoreOptions.VERTEX_CHECK_CUSTOMIZED_ID)
| @@ -235,6 +242,29 @@ protected void prepareAdditions(Map<Id, HugeVertex> addedVertexes, | |||
| } | |||
| } | |||
|
|
|||
| private void checkCustomizedIdVertex(Map<Id, HugeVertex> addedVertexes) { | |||
There was a problem hiding this comment.
checkVertexWithCustomizedId
Linary
force-pushed
the
check-vertex-exist
branch
from
a03f5d1 to
29a3e75
Compare
Linary
force-pushed
the
check-vertex-exist
branch
from
29a3e75 to
6479b43
Compare
javeme
previously requested changes
Nov 15, 2018
| IdQuery idQuery = new IdQuery(HugeType.VERTEX, ids); | ||
| Iterator<HugeVertex> results = this.queryVerticesFromBackend(idQuery); | ||
| if (results.hasNext()) { | ||
| HugeVertex vertex = results.next(); |
There was a problem hiding this comment.
no need to call results.next()
| @@ -207,6 +211,9 @@ protected BackendMutation prepareCommit() { | |||
|
|
|||
| protected void prepareAdditions(Map<Id, HugeVertex> addedVertexes, | |||
| Map<Id, HugeEdge> addedEdges) { | |||
| if (this.checkVertexId) { | |||
| @@ -207,6 +211,9 @@ protected BackendMutation prepareCommit() { | |||
|
|
|||
| protected void prepareAdditions(Map<Id, HugeVertex> addedVertexes, | |||
| Map<Id, HugeEdge> addedEdges) { | |||
| if (this.checkVertexId) { | |||
| this.checkVertexWithCustomizedId(addedVertexes); | |||
There was a problem hiding this comment.
checkVertexExistIfCustomizedId
Linary
force-pushed
the
check-vertex-exist
branch
from
6479b43 to
5edeb6c
Compare
javeme
previously approved these changes
Nov 16, 2018
Linary
force-pushed
the
check-vertex-exist
branch
from
5edeb6c to
55daee5
Compare
javeme
previously approved these changes
Nov 16, 2018
zhoney
previously requested changes
Nov 16, 2018
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
Linary
force-pushed
the
check-vertex-exist
branch
from
55daee5 to
8539d20
Compare
javeme
previously requested changes
Nov 16, 2018
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphTransaction.java
Outdated
Show resolved
Hide resolved
Implement #185 Change-Id: Iabac4af7804aa07c449280cf30eb65ab17d9bd97
Linary
force-pushed
the
check-vertex-exist
branch
from
8539d20 to
908192b
Compare
javeme
approved these changes
Nov 16, 2018
zhoney
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #185
Change-Id: Iabac4af7804aa07c449280cf30eb65ab17d9bd97