Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update git repo for CONTRIBUTING.md #1872

Merged
merged 1 commit into from
May 12, 2022

Conversation

wangyao2016
Copy link
Contributor

Since hugegraph was donated to Apache Foundation, the GitHub repo address has also changed.
So I just update CONTRIBUTING.md when I read it.

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

CONTRIBUTING.md Outdated
```

4. Configure local HugeGraph repo

```shell
cd hugegraph
cd incubator-hugegraph
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can keep hugegraph name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, done.
THANKS

CONTRIBUTING.md Outdated

```shell
# clone code from remote to local repo
git clone https://github.com/${GITHUB_USER_NAME}/hugegraph
git clone https://github.com/${GITHUB_USER_NAME}/incubator-hugegraph.git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer to keep "hugegraph" directory name: git clone git-url directory-name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
THANKS

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1872 (0c0d998) into master (f6f8c3e) will decrease coverage by 4.04%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1872      +/-   ##
============================================
- Coverage     70.95%   66.91%   -4.05%     
- Complexity      695      980     +285     
============================================
  Files           447      447              
  Lines         38077    38077              
  Branches       5401     5401              
============================================
- Hits          27019    25480    -1539     
- Misses         8412    10083    +1671     
+ Partials       2646     2514     -132     
Impacted Files Coverage Δ
...hugegraph/backend/store/raft/RaftStoreClosure.java 0.00% <0.00%> (-100.00%) ⬇️
...ugegraph/backend/store/rocksdb/RocksDBMetrics.java 0.00% <0.00%> (-85.87%) ⬇️
...baidu/hugegraph/backend/store/raft/RaftResult.java 0.00% <0.00%> (-81.25%) ⬇️
...ugegraph/backend/store/raft/RaftSharedContext.java 0.00% <0.00%> (-80.00%) ⬇️
...gegraph/backend/store/rocksdb/RocksDBFeatures.java 8.33% <0.00%> (-79.17%) ⬇️
...hugegraph/backend/store/raft/RaftBackendStore.java 0.00% <0.00%> (-75.00%) ⬇️
...hugegraph/backend/store/raft/rpc/RpcForwarder.java 0.00% <0.00%> (-69.50%) ⬇️
...h/backend/store/raft/RaftBackendStoreProvider.java 0.00% <0.00%> (-67.65%) ⬇️
.../backend/store/raft/rpc/StoreCommandProcessor.java 0.00% <0.00%> (-65.22%) ⬇️
...ugegraph/backend/store/raft/StoreStateMachine.java 0.00% <0.00%> (-62.50%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f8c3e...0c0d998. Read the comment docs.

@wangyao2016 wangyao2016 force-pushed the edit-contributing-branch branch from 265b26d to 0c0d998 Compare May 12, 2022 03:34
@imbajin imbajin changed the title Improve doc: update git repo for CONTRIBUTING.md doc: update git repo for CONTRIBUTING.md May 12, 2022
@imbajin imbajin merged commit 9769406 into apache:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants