Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support query data by use cypher language #1866

Merged
merged 5 commits into from
May 12, 2022

Conversation

jadepeng
Copy link
Contributor

@jadepeng jadepeng commented May 9, 2022

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #1866 (7ad788d) into master (c128b4a) will increase coverage by 4.02%.
The diff coverage is 43.85%.

@@             Coverage Diff              @@
##             master    #1866      +/-   ##
============================================
+ Coverage     66.91%   70.93%   +4.02%     
  Complexity      982      982              
============================================
  Files           447      449       +2     
  Lines         38072    38096      +24     
  Branches       5401     5401              
============================================
+ Hits          25475    27024    +1549     
+ Misses        10082     8425    -1657     
- Partials       2515     2647     +132     
Impacted Files Coverage Δ
...ava/com/baidu/hugegraph/api/gremlin/CypherAPI.java 0.00% <0.00%> (ø)
...m/baidu/hugegraph/api/gremlin/GremlinQueryAPI.java 63.88% <63.88%> (ø)
...va/com/baidu/hugegraph/api/gremlin/GremlinAPI.java 100.00% <100.00%> (+25.00%) ⬆️
...n/java/com/baidu/hugegraph/version/ApiVersion.java 75.00% <100.00%> (ø)
.../backend/store/cassandra/CassandraSessionPool.java 59.00% <0.00%> (-0.60%) ⬇️
...va/com/baidu/hugegraph/util/collection/IntMap.java 72.40% <0.00%> (-0.40%) ⬇️
...aidu/hugegraph/backend/store/hbase/HbaseTable.java 75.92% <0.00%> (ø)
...idu/hugegraph/backend/store/hbase/HbaseTables.java 90.00% <0.00%> (ø)
...ugegraph/backend/store/rocksdb/RocksDBOptions.java 99.25% <0.00%> (ø)
...gegraph/backend/store/rocksdb/RocksDBSessions.java 100.00% <0.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c128b4a...7ad788d. Read the comment docs.

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature! Thanks for your contribution

javeme
javeme previously approved these changes May 10, 2022
Copy link
Member

@coderzc coderzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could add more cases in client side

@javeme javeme merged commit cd09304 into apache:master May 12, 2022
@seagle-yuan
Copy link
Contributor

@jadepeng can you modify this code to pass the checkstyle check?

xhtian95 pushed a commit to xhtian95/hugegraph that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants