fix hugegraph-hbase and hugegraph-example checkstyle issue #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into bugfix-branch
mayelena
changed the title
javeme
reviewed
May 7, 2022
| @@ -283,7 +283,8 @@ protected BackendEntryIterator newEntryIterator(Query query, | |||
| }); | |||
| } | |||
|
|
|||
| protected void parseRowColumns(Result row, BackendEntry entry, Query query, boolean enablePartition) | |||
| protected void parseRowColumns(Result row, BackendEntry entry, Query query, | |||
| boolean enablePartition) | |||
| @@ -54,7 +54,7 @@ public abstract class HbaseStore extends AbstractBackendStore<Session> { | |||
|
|
|||
| private static final Logger LOG = Log.logger(HbaseStore.class); | |||
|
|
|||
| private final BackendFeatures FEATURES; | |||
| private final BackendFeatures features; | |||
| @@ -84,6 +86,7 @@ | |||
| import com.google.common.util.concurrent.Futures; | |||
|
|
|||
| public class HbaseSessions extends BackendSessionPool { | |||
| private static final Logger LOG = Log.logger(HbaseSessions.class); | |||
There was a problem hiding this comment.
add a blank line after class define
| TableDescriptorBuilder builder = TableDescriptorBuilder.newBuilder( | ||
| TableName.valueOf(this.namespace, table)); | ||
| for (byte[] cf : cfs) { | ||
| builder.setColumnFamily(ColumnFamilyDescriptorBuilder.newBuilder(cf) | ||
| .build()); | ||
| } | ||
| byte[][] splits = new byte[numOfPartitions - 1][org.apache.hadoop.hbase.util.Bytes.SIZEOF_SHORT]; | ||
| byte[][] splits = new byte[numOfPartitions - 1][org.apache.hadoop |
There was a problem hiding this comment.
prefer to wrap line before "[org"
| @@ -793,18 +798,18 @@ public long storeSize(String table) throws IOException { | |||
| */ | |||
| @SuppressWarnings("unused") | |||
| private void dump(String table, Scan scan) throws IOException { | |||
| System.out.println(String.format(">>>> scan table %s with %s", | |||
| LOG.info(String.format(">>>> scan table %s with %s", | |||
There was a problem hiding this comment.
LOG.info(">>>> scan table {} with {}",
| CellScanner cellScanner = row.cellScanner(); | ||
| while (cellScanner.advance()) { | ||
| Cell cell = cellScanner.current(); | ||
| byte[] key = CellUtil.cloneQualifier(cell); | ||
| byte[] val = CellUtil.cloneValue(cell); | ||
| System.out.println(String.format(" %s=%s", | ||
| LOG.info(String.format(" %s=%s", |
| @@ -445,7 +447,8 @@ public static class HbaseSchemaStore extends HbaseStore { | |||
|
|
|||
| public HbaseSchemaStore(HugeConfig config, BackendStoreProvider provider, | |||
| String namespace, String store) { | |||
| super(provider, namespace, store, config.get(HbaseOptions.HBASE_ENABLE_PARTITION).booleanValue()); | |||
| super(provider, namespace, store, config.get(HbaseOptions | |||
| @@ -492,7 +495,8 @@ public static class HbaseGraphStore extends HbaseStore { | |||
| private boolean enablePartition; | |||
| public HbaseGraphStore(HugeConfig config, BackendStoreProvider provider, | |||
| String namespace, String store) { | |||
| super(provider, namespace, store, config.get(HbaseOptions.HBASE_ENABLE_PARTITION).booleanValue()); | |||
| super(provider, namespace, store, config.get(HbaseOptions.HBASE_ENABLE_PARTITION) | |||
javeme
reviewed
May 7, 2022
| @@ -30,7 +30,7 @@ public class ThreadRangePerfTest { | |||
|
|
|||
| public static void main(String[] args) throws Exception { | |||
| if (args.length != 6) { | |||
| System.out.println("Usage: minThread maxThread threadStep " + | |||
| LOG.info("Usage: minThread maxThread threadStep " + | |||
| LOG.info("Insert rate with threads: {} vertices/s & {} edges/s, " + | ||
| "insert total {} vertices & {} edges, cost time: {}ms", | ||
| LOG.info("Insert rate with threads: {} vertices/s & {} edges/s, | ||
| insert total {} vertices & {} edges, cost time: {}ms", |
There was a problem hiding this comment.
there is a syntax error here, please keep the origin code
| LOG.info("Query rate with threads: {} vertices/s, " + | ||
| "query total vertices {}, cost time: {}ms", | ||
| LOG.info("Query rate with threads: {} vertices/s, | ||
| query total vertices {}, cost time: {}ms", |
javeme
reviewed
May 7, 2022
|
|
||
| // query edges by condition | ||
| List<Edge> tomhanksMovies = graph.traversal().V() | ||
| .hasLabel("person") | ||
| .has("name", "Tom Hanks") | ||
| .outE("ACTED_IN").toList(); | ||
| System.out.println(">>>> Tom Hanks ACTED_IN: " + tomhanksMovies); | ||
| LOG.info{(">>>> Tom Hanks ACTED_IN: {}", tomhanksMovies); |
javeme
reviewed
May 8, 2022
|
|
||
| G.addEdge("directedBy", M); | ||
| G.addEdge("directedBy", m); |
There was a problem hiding this comment.
Error: /home/runner/work/incubator-hugegraph/incubator-hugegraph/hugegraph-example/src/main/java/com/baidu/hugegraph/example/Example3.java:[122,9] cannot find symbol
symbol: variable G
location: class com.baidu.hugegraph.example.Example3
javeme
previously approved these changes
May 8, 2022
Codecov Report
@@ Coverage Diff @@
## master #1864 +/- ##
============================================
+ Coverage 66.96% 70.95% +3.99%
Complexity 980 980
============================================
Files 447 447
Lines 38045 38072 +27
Branches 5391 5401 +10
============================================
+ Hits 25477 27015 +1538
+ Misses 10065 8410 -1655
- Partials 2503 2647 +144
Continue to review full report at Codecov.
|
imbajin
reviewed
May 9, 2022
There was a problem hiding this comment.
@seagle-yuan if we don't divide these case, will it hit against the check-style?
Comment on lines
239
to
240
| builder.setColumnFamily(ColumnFamilyDescriptorBuilder.newBuilder(cf) | ||
| .build()); |
There was a problem hiding this comment.
No rules will be hit.
The below line is indented more than 4 blankspace.
And we setted forceStrictCondition = false, so more than 4 space is ok.
https://checkstyle.sourceforge.io/config_misc.html#Indentation.
there isn't any rules about align in all checkstyle rules
Comment on lines
+242
to
+243
| byte[][] splits = new byte[numOfPartitions - 1] | ||
| [org.apache.hadoop.hbase.util.Bytes.SIZEOF_SHORT]; |
There was a problem hiding this comment.
seems divide it makes a little strange for readable
There was a problem hiding this comment.
it rely on the setting of IDE
javeme
reviewed
May 9, 2022
| CellScanner cellScanner = row.cellScanner(); | ||
| while (cellScanner.advance()) { | ||
| Cell cell = cellScanner.current(); | ||
| byte[] key = CellUtil.cloneQualifier(cell); | ||
| byte[] val = CellUtil.cloneValue(cell); | ||
| System.out.println(String.format(" %s=%s", | ||
| LOG.info(String.format(" {}={}", |
There was a problem hiding this comment.
remove String.format and update alignment
javeme
approved these changes
May 9, 2022
imbajin
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.