Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix core-backend checkstyle issue #1852

Merged
merged 19 commits into from
May 12, 2022
Merged

Conversation

seagle-yuan
Copy link
Contributor

@seagle-yuan seagle-yuan commented Apr 26, 2022

fix checkstyle issue for package com.baidu.hugegraph.backend

com.baidu.hugegraph.backend.id.EdgeId.java
com.baidu.hugegraph.backend.query.Condition.java
com.baidu.hugegraph.backend.query.ConditionQuery.java
com.baidu.hugegraph.backend.query.ConditionQueryFlatten.java
com.baidu.hugegraph.backend.query.Query.java
com.baidu.hugegraph.backend.query.IdRangeQuery.java
com.baidu.hugegraph.backend.serializer.BinaryEntryIterator.java
com.baidu.hugegraph.backend.serializer.BinarySerializer.java
com.baidu.hugegraph.backend.serializer.GraphSerializer.java
com.baidu.hugegraph.backend.serializer.SchemaSerializer.java
com.baidu.hugegraph.backend.store.raft.RaftBackendStore.java
com.baidu.hugegraph.backend.store.ram.RamTable.java
com.baidu.hugegraph.backend.store.BackendEntry.java
com.baidu.hugegraph.backend.store.BackendMutation.java
com.baidu.hugegraph.backend.store.BackendSession.java
com.baidu.hugegraph.backend.store.BackendStore.java
com.baidu.hugegraph.backend.store.BackendStoreProvider.java
com.baidu.hugegraph.backend.store.BackendTable.java
com.baidu.hugegraph.backend.store.MetaHandler.java
com.baidu.hugegraph.backend.tx.GraphIndexTransaction.java
com.baidu.hugegraph.backend.tx.GraphTransaction.java

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1852 (7f90204) into master (f6f8c3e) will increase coverage by 0.01%.
The diff coverage is 85.71%.

@@             Coverage Diff              @@
##             master    #1852      +/-   ##
============================================
+ Coverage     70.95%   70.97%   +0.01%     
- Complexity      695      982     +287     
============================================
  Files           447      447              
  Lines         38077    38096      +19     
  Branches       5401     5404       +3     
============================================
+ Hits          27019    27039      +20     
+ Misses         8412     8410       -2     
- Partials       2646     2647       +1     
Impacted Files Coverage Δ
...in/java/com/baidu/hugegraph/backend/id/EdgeId.java 79.13% <ø> (ø)
.../baidu/hugegraph/backend/query/ConditionQuery.java 85.88% <ø> (ø)
...egraph/backend/serializer/BinaryEntryIterator.java 87.03% <ø> (ø)
.../baidu/hugegraph/backend/store/BackendSession.java 80.95% <ø> (ø)
...om/baidu/hugegraph/backend/store/BackendTable.java 86.75% <ø> (ø)
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.14% <0.00%> (ø)
...om/baidu/hugegraph/backend/store/BackendEntry.java 68.62% <66.66%> (-2.81%) ⬇️
...hugegraph/backend/store/raft/RaftBackendStore.java 74.72% <66.66%> (-0.28%) ⬇️
...du/hugegraph/backend/tx/GraphIndexTransaction.java 83.66% <71.42%> (+0.08%) ⬆️
...om/baidu/hugegraph/backend/store/BackendStore.java 79.54% <80.95%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6f8c3e...7f90204. Read the comment docs.

@seagle-yuan seagle-yuan changed the title fix core-issue checkstyle issue fix core-backendcheckstyle issue Apr 26, 2022
@seagle-yuan seagle-yuan changed the title fix core-backendcheckstyle issue fix core-backend checkstyle issue Apr 26, 2022
@javeme
Copy link
Contributor

javeme commented May 4, 2022

cassandra ci:

Error:  Tests run: 727, Failures: 3, Errors: 1, Skipped: 21, Time elapsed: 482.636 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
Error:  testQueryVertexBeforeAfterUpdateMultiPropertyWithIndex(com.baidu.hugegraph.core.VertexCoreTest)  Time elapsed: 0.541 s  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
	at com.baidu.hugegraph.core.VertexCoreTest.testQueryVertexBeforeAfterUpdateMultiPropertyWithIndex(VertexCoreTest.java:6465)

Error:  testAddVertexWithCollectionIndex(com.baidu.hugegraph.core.VertexCoreTest)  Time elapsed: 0.523 s  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
	at com.baidu.hugegraph.core.VertexCoreTest.testAddVertexWithCollectionIndex(VertexCoreTest.java:676)

Error:  testAddEdgeWithCollectionIndex(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.37 s  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
	at com.baidu.hugegraph.core.EdgeCoreTest.testAddEdgeWithCollectionIndex(EdgeCoreTest.java:7334)

Error:  testUpdateEdgePropertyWithRemoveAndSet(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.49 s  <<< ERROR!
java.lang.IllegalStateException: The property does not exist as it has no key, value, or associated element
	at com.baidu.hugegraph.core.EdgeCoreTest.assertContains(EdgeCoreTest.java:7465)
	at com.baidu.hugegraph.core.EdgeCoreTest.testUpdateEdgePropertyWithRemoveAndSet(EdgeCoreTest.java:5938)

hbase ci:

Error:  Tests run: 727, Failures: 3, Errors: 0, Skipped: 35, Time elapsed: 873.651 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
Error:  testQueryVertexBeforeAfterUpdateMultiPropertyWithIndex(com.baidu.hugegraph.core.VertexCoreTest)  Time elapsed: 0.547 s  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
	at com.baidu.hugegraph.core.VertexCoreTest.testQueryVertexBeforeAfterUpdateMultiPropertyWithIndex(VertexCoreTest.java:6465)

Error:  testAddVertexWithCollectionIndex(com.baidu.hugegraph.core.VertexCoreTest)  Time elapsed: 0.537 s  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
	at com.baidu.hugegraph.core.VertexCoreTest.testAddVertexWithCollectionIndex(VertexCoreTest.java:676)

Error:  testAddEdgeWithCollectionIndex(com.baidu.hugegraph.core.EdgeCoreTest)  Time elapsed: 0.413 s  <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
	at com.baidu.hugegraph.core.EdgeCoreTest.testAddEdgeWithCollectionIndex(EdgeCoreTest.java:7334)

@javeme
Copy link
Contributor

javeme commented May 7, 2022

@seagle-yuan there are still comments~

@seagle-yuan seagle-yuan requested a review from javeme May 11, 2022 04:03
@seagle-yuan seagle-yuan requested a review from javeme May 11, 2022 10:53
@javeme javeme merged commit d4304b6 into apache:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants