-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix core-backend checkstyle issue #1852
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1852 +/- ##
============================================
+ Coverage 70.95% 70.97% +0.01%
- Complexity 695 982 +287
============================================
Files 447 447
Lines 38077 38096 +19
Branches 5401 5404 +3
============================================
+ Hits 27019 27039 +20
+ Misses 8412 8410 -2
- Partials 2646 2647 +1
Continue to review full report at Codecov.
|
javeme
reviewed
Apr 26, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/raft/RaftBackendStore.java
Outdated
Show resolved
Hide resolved
seagle-yuan
changed the title
fix core-issue checkstyle issue
fix core-backendcheckstyle issue
Apr 26, 2022
seagle-yuan
changed the title
fix core-backendcheckstyle issue
fix core-backend checkstyle issue
Apr 26, 2022
javeme
reviewed
Apr 27, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendEntry.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendEntry.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendEntry.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendEntry.java
Show resolved
Hide resolved
javeme
reviewed
Apr 27, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendStore.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Apr 27, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendStore.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
May 4, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/IdRangeQuery.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendMutation.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendStore.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendStore.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/tx/GraphIndexTransaction.java
Outdated
Show resolved
Hide resolved
cassandra ci: Error: Tests run: 727, Failures: 3, Errors: 1, Skipped: 21, Time elapsed: 482.636 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
Error: testQueryVertexBeforeAfterUpdateMultiPropertyWithIndex(com.baidu.hugegraph.core.VertexCoreTest) Time elapsed: 0.541 s <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
at com.baidu.hugegraph.core.VertexCoreTest.testQueryVertexBeforeAfterUpdateMultiPropertyWithIndex(VertexCoreTest.java:6465)
Error: testAddVertexWithCollectionIndex(com.baidu.hugegraph.core.VertexCoreTest) Time elapsed: 0.523 s <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
at com.baidu.hugegraph.core.VertexCoreTest.testAddVertexWithCollectionIndex(VertexCoreTest.java:676)
Error: testAddEdgeWithCollectionIndex(com.baidu.hugegraph.core.EdgeCoreTest) Time elapsed: 0.37 s <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
at com.baidu.hugegraph.core.EdgeCoreTest.testAddEdgeWithCollectionIndex(EdgeCoreTest.java:7334)
Error: testUpdateEdgePropertyWithRemoveAndSet(com.baidu.hugegraph.core.EdgeCoreTest) Time elapsed: 0.49 s <<< ERROR!
java.lang.IllegalStateException: The property does not exist as it has no key, value, or associated element
at com.baidu.hugegraph.core.EdgeCoreTest.assertContains(EdgeCoreTest.java:7465)
at com.baidu.hugegraph.core.EdgeCoreTest.testUpdateEdgePropertyWithRemoveAndSet(EdgeCoreTest.java:5938) hbase ci: Error: Tests run: 727, Failures: 3, Errors: 0, Skipped: 35, Time elapsed: 873.651 s <<< FAILURE! - in com.baidu.hugegraph.core.CoreTestSuite
Error: testQueryVertexBeforeAfterUpdateMultiPropertyWithIndex(com.baidu.hugegraph.core.VertexCoreTest) Time elapsed: 0.547 s <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
at com.baidu.hugegraph.core.VertexCoreTest.testQueryVertexBeforeAfterUpdateMultiPropertyWithIndex(VertexCoreTest.java:6465)
Error: testAddVertexWithCollectionIndex(com.baidu.hugegraph.core.VertexCoreTest) Time elapsed: 0.537 s <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
at com.baidu.hugegraph.core.VertexCoreTest.testAddVertexWithCollectionIndex(VertexCoreTest.java:676)
Error: testAddEdgeWithCollectionIndex(com.baidu.hugegraph.core.EdgeCoreTest) Time elapsed: 0.413 s <<< FAILURE!
java.lang.AssertionError: expected:<1> but was:<0>
at com.baidu.hugegraph.core.EdgeCoreTest.testAddEdgeWithCollectionIndex(EdgeCoreTest.java:7334) |
javeme
reviewed
May 4, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendMutation.java
Show resolved
Hide resolved
javeme
reviewed
May 5, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendMutation.java
Show resolved
Hide resolved
@seagle-yuan there are still comments~ |
javeme
previously approved these changes
May 11, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/store/BackendMutation.java
Show resolved
Hide resolved
imbajin
reviewed
May 11, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/query/ConditionQuery.java
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/backend/serializer/BinarySerializer.java
Outdated
Show resolved
Hide resolved
imbajin
approved these changes
May 11, 2022
javeme
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix checkstyle issue for package
com.baidu.hugegraph.backend