Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve ClassTypeParameterName check #1850

Merged
merged 10 commits into from
Apr 25, 2022

Conversation

seagle-yuan
Copy link
Contributor

@seagle-yuan seagle-yuan commented Apr 25, 2022

resubmit checkstyle file
#1833
#1826

improve ClassTypeParameterName check
the regular expression of "ClassTypeParameterName "
from "(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9][T]$)" to "[A-Z][a-zA-Z0-9]$"

@seagle-yuan seagle-yuan changed the title Checkstyle check resubmit Checkstyle file and improve ClassTypeParameterName check Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1850 (53d31db) into master (85b01b2) will increase coverage by 6.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1850      +/-   ##
============================================
+ Coverage     64.45%   70.82%   +6.36%     
- Complexity      914      980      +66     
============================================
  Files           447      447              
  Lines         38040    38040              
  Branches       5389     5389              
============================================
+ Hits          24520    26943    +2423     
+ Misses        11000     8464    -2536     
- Partials       2520     2633     +113     
Impacted Files Coverage Δ
...m/baidu/hugegraph/io/GraphSONSchemaSerializer.java 84.61% <0.00%> (ø)
...hugegraph/backend/store/raft/rpc/RaftRequests.java 27.85% <0.00%> (+0.06%) ⬆️
...in/java/com/baidu/hugegraph/StandardHugeGraph.java 66.95% <0.00%> (+0.35%) ⬆️
.../baidu/hugegraph/backend/query/ConditionQuery.java 85.88% <0.00%> (+0.48%) ⬆️
...ugegraph/backend/store/raft/StoreStateMachine.java 63.39% <0.00%> (+0.89%) ⬆️
...ava/com/baidu/hugegraph/io/HugeGraphSONModule.java 82.88% <0.00%> (+0.90%) ⬆️
...main/java/com/baidu/hugegraph/auth/HugeTarget.java 79.20% <0.00%> (+0.99%) ⬆️
...u/hugegraph/schema/builder/VertexLabelBuilder.java 87.59% <0.00%> (+1.12%) ⬆️
.../hugegraph/backend/store/rocksdb/RocksDBTable.java 68.49% <0.00%> (+1.36%) ⬆️
...in/java/com/baidu/hugegraph/core/GraphManager.java 44.48% <0.00%> (+1.57%) ⬆️
... and 88 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b01b2...53d31db. Read the comment docs.

@javeme javeme changed the title resubmit Checkstyle file and improve ClassTypeParameterName check improve ClassTypeParameterName check Apr 25, 2022
@seagle-yuan seagle-yuan mentioned this pull request Apr 25, 2022
@imbajin imbajin merged commit 4484775 into apache:master Apr 25, 2022
@seagle-yuan seagle-yuan deleted the checkstyle-check branch April 26, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants