Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix checkstyle IdHolder&AuthManager issue #1846

Merged
merged 10 commits into from
Apr 26, 2022

Conversation

seagle-yuan
Copy link
Contributor

@seagle-yuan seagle-yuan commented Apr 24, 2022

relate to #1835
fix checkstyle issue

com.baidu.hugegraph.backend.page.IdHolder delete extra semicolons
com.baidu.hugegraph.auth.AuthManager add empty line and delete "public" word

@codecov
Copy link

codecov bot commented Apr 24, 2022

Codecov Report

Merging #1846 (6461465) into master (b991b6a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1846      +/-   ##
============================================
- Coverage     70.81%   70.78%   -0.04%     
+ Complexity      982      693     -289     
============================================
  Files           447      447              
  Lines         38040    38040              
  Branches       5389     5389              
============================================
- Hits          26938    26925      -13     
- Misses         8469     8484      +15     
+ Partials       2633     2631       -2     
Impacted Files Coverage Δ
...ava/com/baidu/hugegraph/backend/page/IdHolder.java 80.85% <100.00%> (ø)
...baidu/hugegraph/backend/store/raft/RaftResult.java 81.25% <0.00%> (-18.75%) ⬇️
...aidu/hugegraph/backend/store/raft/RaftClosure.java 44.82% <0.00%> (-17.25%) ⬇️
...hugegraph/backend/store/raft/RaftBackendStore.java 75.00% <0.00%> (-6.53%) ⬇️
...m/baidu/hugegraph/backend/store/raft/RaftNode.java 47.65% <0.00%> (-4.70%) ⬇️
...va/com/baidu/hugegraph/task/ServerInfoManager.java 76.75% <0.00%> (-3.25%) ⬇️
...hugegraph/backend/store/raft/rpc/RaftRequests.java 27.92% <0.00%> (+0.06%) ⬆️
...va/com/baidu/hugegraph/util/collection/IntSet.java 75.00% <0.00%> (+1.27%) ⬆️
.../hugegraph/backend/store/rocksdb/RocksDBStore.java 69.71% <0.00%> (+1.52%) ⬆️
...ugegraph/backend/store/raft/StoreStateMachine.java 65.17% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b991b6a...6461465. Read the comment docs.

@seagle-yuan seagle-yuan changed the title fix checkstyle IdHolder issue fix checkstyle IdHolder&AuthManager issue Apr 25, 2022
@seagle-yuan
Copy link
Contributor Author

seagle-yuan commented Apr 26, 2022

It seems like the probability of failure is hign
3

1
2

Error:  Failures: 
Error:    EdgeApiTest>BaseApiTest.init:82->BaseApiTest.clearData:600->BaseApiTest.clearSchema:541->BaseApiTest.lambda$clearSchema$5:520->BaseApiTest.assertResponseStatus:617 Response with status 400 and content {"exception":"class com.baidu.hugegraph.HugeException","message":"Failed to serialize indexlabels","cause":"com.baidu.hugegraph.HugeException: Can't write json: Undefined vertex label with id: '24' (through reference chain: java.util.ArrayList[0])"} expected:<200> but was:<400>
Error:    GremlinApiTest>BaseApiTest.init:82->BaseApiTest.clearData:600->BaseApiTest.clearSchema:541->BaseApiTest.lambda$clearSchema$5:520->BaseApiTest.assertResponseStatus:617 Response with status 400 and content {"exception":"class com.baidu.hugegraph.HugeException","message":"Failed to serialize indexlabels","cause":"com.baidu.hugegraph.HugeException: Can't write json: Undefined vertex label with id: '24' (through reference chain: java.util.ArrayList[0])"} expected:<200> but was:<400>
Error:  com.baidu.hugegraph.api.IndexLabelApiTest.testDelete(com.baidu.hugegraph.api.IndexLabelApiTest)
Error:    Run 1: IndexLabelApiTest.testDelete:149->BaseApiTest.assertResponseStatus:617 Response with status 400 and content {"exception":"class com.baidu.hugegraph.exception.ExistedException","message":"The index label 'personByAge' has existed","cause":""} expected:<202> but was:<400>
Error:    Run 2: IndexLabelApiTest>BaseApiTest.teardown:92->BaseApiTest.clearData:600->BaseApiTest.clearSchema:541->BaseApiTest.lambda$clearSchema$5:520->BaseApiTest.assertResponseStatus:617 Response with status 400 and content {"exception":"class com.baidu.hugegraph.HugeException","message":"Failed to serialize indexlabels","cause":"com.baidu.hugegraph.HugeException: Can't write json: Undefined vertex label with id: '24' (through reference chain: java.util.ArrayList[0])"} expected:<200> but was:<400>

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we could unify all interface (remove public static?)

@imbajin imbajin merged commit 0ed2e3b into apache:master Apr 26, 2022
@seagle-yuan seagle-yuan deleted the checkstyle-IdHolder branch May 3, 2022 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants