Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: add how to create a GitHub token #1820

Merged
merged 1 commit into from
Apr 16, 2022
Merged

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Apr 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1820 (9e7c702) into master (73a1f1f) will increase coverage by 4.32%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1820      +/-   ##
============================================
+ Coverage     66.56%   70.89%   +4.32%     
- Complexity      978      980       +2     
============================================
  Files           446      446              
  Lines         37902    37902              
  Branches       5398     5398              
============================================
+ Hits          25230    26870    +1640     
+ Misses         9967     8301    -1666     
- Partials       2705     2731      +26     
Impacted Files Coverage Δ
...du/hugegraph/backend/tx/GraphIndexTransaction.java 83.82% <0.00%> (+0.21%) ⬆️
...du/hugegraph/traversal/optimize/TraversalUtil.java 62.87% <0.00%> (+0.21%) ⬆️
.../baidu/hugegraph/backend/query/ConditionQuery.java 85.64% <0.00%> (+0.24%) ⬆️
...du/hugegraph/schema/builder/IndexLabelBuilder.java 88.69% <0.00%> (+0.28%) ⬆️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.08% <0.00%> (+0.30%) ⬆️
.../com/baidu/hugegraph/auth/StandardAuthManager.java 92.81% <0.00%> (+0.32%) ⬆️
...idu/hugegraph/schema/builder/EdgeLabelBuilder.java 83.62% <0.00%> (+0.34%) ⬆️
...u/hugegraph/schema/builder/VertexLabelBuilder.java 87.54% <0.00%> (+0.37%) ⬆️
.../java/com/baidu/hugegraph/backend/query/Query.java 86.11% <0.00%> (+0.39%) ⬆️
...hugegraph/backend/query/ConditionQueryFlatten.java 76.15% <0.00%> (+0.41%) ⬆️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a1f1f...9e7c702. Read the comment docs.

@@ -103,6 +103,9 @@ Push the local commit to GitHub fork repo:
git push origin bugfix-branch:bugfix-branch
```

Note that since GitHub requires submitting code through `username + token` (instead of using `username + password` directly), you need to create a GitHub token from https://github.com/settings/tokens:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems it's not necessary for normal user/dev to use this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly for new contributors

Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo:

  • we should let dev use ssh to push code later (not recommend for http way)

@imbajin imbajin merged commit 7438511 into master Apr 16, 2022
@imbajin imbajin deleted the javeme-patch-2 branch April 16, 2022 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants