-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CONTRIBUTING.md: add how to create a GitHub token #1820
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1820 +/- ##
============================================
+ Coverage 66.56% 70.89% +4.32%
- Complexity 978 980 +2
============================================
Files 446 446
Lines 37902 37902
Branches 5398 5398
============================================
+ Hits 25230 26870 +1640
+ Misses 9967 8301 -1666
- Partials 2705 2731 +26
Continue to review full report at Codecov.
|
@@ -103,6 +103,9 @@ Push the local commit to GitHub fork repo: | |||
git push origin bugfix-branch:bugfix-branch | |||
``` | |||
|
|||
Note that since GitHub requires submitting code through `username + token` (instead of using `username + password` directly), you need to create a GitHub token from https://github.com/settings/tokens: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems it's not necessary for normal user/dev to use this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainly for new contributors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo:
- we should let dev use
ssh
to push code later (not recommend for http way)
No description provided.