Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING.md: correct how to sign the CLA #1819

Merged
merged 2 commits into from
Apr 18, 2022
Merged

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Apr 15, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #1819 (256fb57) into master (73a1f1f) will increase coverage by 4.34%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1819      +/-   ##
============================================
+ Coverage     66.56%   70.90%   +4.34%     
- Complexity      978      980       +2     
============================================
  Files           446      446              
  Lines         37902    37903       +1     
  Branches       5398     5399       +1     
============================================
+ Hits          25230    26877    +1647     
+ Misses         9967     8296    -1671     
- Partials       2705     2730      +25     
Impacted Files Coverage Δ
...du/hugegraph/backend/tx/GraphIndexTransaction.java 83.82% <0.00%> (+0.21%) ⬆️
...du/hugegraph/traversal/optimize/TraversalUtil.java 62.87% <0.00%> (+0.21%) ⬆️
.../baidu/hugegraph/backend/query/ConditionQuery.java 85.64% <0.00%> (+0.24%) ⬆️
...du/hugegraph/schema/builder/IndexLabelBuilder.java 88.69% <0.00%> (+0.28%) ⬆️
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.08% <0.00%> (+0.30%) ⬆️
.../com/baidu/hugegraph/auth/StandardAuthManager.java 92.81% <0.00%> (+0.32%) ⬆️
...idu/hugegraph/schema/builder/EdgeLabelBuilder.java 83.62% <0.00%> (+0.34%) ⬆️
...u/hugegraph/schema/builder/VertexLabelBuilder.java 87.54% <0.00%> (+0.37%) ⬆️
.../java/com/baidu/hugegraph/backend/query/Query.java 86.11% <0.00%> (+0.39%) ⬆️
...va/com/baidu/hugegraph/util/collection/IntMap.java 72.00% <0.00%> (+0.40%) ⬆️
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a1f1f...256fb57. Read the comment docs.

CONTRIBUTING.md Outdated

`I have read the CLA Document and I hereby sign the CLA`

Note that please make sure the email address you submit the code is bound to the GitHub account. For how to bind the email address, please refer to https://github.com/settings/emails:
Copy link
Member

@imbajin imbajin Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo and simplify:

Note: please make sure the code you submit has bounded with the email address in your GitHub account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, most users use emails bound to the github, but some users have already submitted the code with different email and pushed it to github, then trigger this problem, so here is a note that more emails can be bound to github.

corgiboygsj
corgiboygsj previously approved these changes Apr 15, 2022
@corgiboygsj corgiboygsj merged commit 9ec3c3c into master Apr 18, 2022
@corgiboygsj corgiboygsj deleted the javeme-patch-1 branch April 18, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants