feat: add ingore security check api #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot Good! All Contributors have signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## master #1784 +/- ##
============================================
+ Coverage 66.86% 70.83% +3.96%
- Complexity 970 976 +6
============================================
Files 443 446 +3
Lines 37749 37809 +60
Branches 5384 5393 +9
============================================
+ Hits 25241 26782 +1541
+ Misses 9784 8299 -1485
- Partials 2724 2728 +4
Continue to review full report at Codecov.
|
javeme
reviewed
Mar 18, 2022
hugegraph-core/src/main/java/com/baidu/hugegraph/security/HugeSecurityManager.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/security/HugeSecurityManager.java
Outdated
Show resolved
Hide resolved
| public static void addIgnoreCheck(String clazz) { | ||
| if (callFromGremlin()) { | ||
| throw newSecurityException( | ||
| "Not allowed to add ignore check via Gremlin"); |
There was a problem hiding this comment.
I think this method be called when inited best, if add ignore-checked, maybe it is called on other time;
hugegraph-core/src/main/java/com/baidu/hugegraph/security/HugeSecurityManager.java
Outdated
Show resolved
Hide resolved
javeme
approved these changes
Mar 21, 2022
|
I have read the CLA Document and I hereby sign the CLA |
zhoney
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.