fix edge batch update error #1776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I8742ca0e128e3c9bc3eb2ef99a52276045e17b79
Codecov Report
@@ Coverage Diff @@
## master #1776 +/- ##
============================================
- Coverage 66.85% 66.84% -0.02%
+ Complexity 972 970 -2
============================================
Files 443 443
Lines 37738 37738
Branches 5381 5381
============================================
- Hits 25229 25225 -4
- Misses 9788 9793 +5
+ Partials 2721 2720 -1
Continue to review full report at Codecov.
|
javeme
approved these changes
Mar 9, 2022
imbajin
approved these changes
Mar 9, 2022
| @@ -464,7 +464,7 @@ private Id getEdgeId(HugeGraph g, JsonEdge newEdge) { | |||
| Directions.OUT, labelId, sortKeys, | |||
| HugeVertex.getIdValue(newEdge.target)); | |||
| if (newEdge.id != null) { | |||
| E.checkArgument(edgeId.equals(newEdge.id), | |||
| E.checkArgument(edgeId.asString().equals(newEdge.id), | |||
There was a problem hiding this comment.
wonder in which case the edgeId can't compare with jsonEdgeId?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I8742ca0e128e3c9bc3eb2ef99a52276045e17b79