Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected task status #1767

Merged
merged 4 commits into from
Mar 11, 2022
Merged

Fix unexpected task status #1767

merged 4 commits into from
Mar 11, 2022

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Feb 28, 2022

related: #1738

Change-Id: I9eb0b260611e6b65280969d96b8e5856403cc583
Change-Id: Ia42fdbf28ac7428501fb36bc89e5ab4368a0b553
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #1767 (13c2567) into master (5cdf770) will increase coverage by 7.52%.
The diff coverage is 82.60%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1767      +/-   ##
============================================
+ Coverage     63.26%   70.79%   +7.52%     
- Complexity      684      970     +286     
============================================
  Files           443      443              
  Lines         37738    37748      +10     
  Branches       5381     5383       +2     
============================================
+ Hits          23875    26722    +2847     
+ Misses        11247     8305    -2942     
- Partials       2616     2721     +105     
Impacted Files Coverage Δ
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 72.30% <ø> (+0.61%) ⬆️
...ain/java/com/baidu/hugegraph/task/TaskManager.java 74.82% <ø> (+6.47%) ⬆️
...va/com/baidu/hugegraph/task/ServerInfoManager.java 78.49% <80.00%> (+5.46%) ⬆️
...main/java/com/baidu/hugegraph/api/job/TaskAPI.java 51.02% <100.00%> (ø)
...om/baidu/hugegraph/task/StandardTaskScheduler.java 76.21% <100.00%> (+1.09%) ⬆️
...du/hugegraph/traversal/optimize/TraversalUtil.java 62.60% <0.00%> (+0.21%) ⬆️
.../com/baidu/hugegraph/auth/StandardAuthManager.java 92.81% <0.00%> (+0.32%) ⬆️
...idu/hugegraph/schema/builder/EdgeLabelBuilder.java 83.62% <0.00%> (+0.34%) ⬆️
...u/hugegraph/schema/builder/VertexLabelBuilder.java 85.44% <0.00%> (+0.37%) ⬆️
.../java/com/baidu/hugegraph/backend/query/Query.java 86.11% <0.00%> (+0.39%) ⬆️
... and 127 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cdf770...13c2567. Read the comment docs.

@javeme
Copy link
Contributor Author

javeme commented Feb 28, 2022

ci error of shared storage:

[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running com.baidu.hugegraph.api.ApiTestSuite
Error:  Tests run: 84, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 88.882 s <<< FAILURE! - in com.baidu.hugegraph.api.ApiTestSuite
Error:  testClearAndInit(com.baidu.hugegraph.api.GremlinApiTest)  Time elapsed: 46.267 s  <<< FAILURE!
java.lang.AssertionError: Response with status 400 and content {"exception":"java.lang.IllegalArgumentException","message":"Already existed master 'server-1' in current cluster","cause":"[java.lang.IllegalArgumentException]"} expected:<200> but was:<400>
	at com.baidu.hugegraph.api.GremlinApiTest.testClearAndInit(GremlinApiTest.java:124)

Change-Id: I36bfd4d556edbdc2e5c1d9863dcf471802682720
imbajin
imbajin previously approved these changes Mar 2, 2022
Change-Id: I5eca4b6663ad85e10a75dfc9c813e2aa35ab2078
@corgiboygsj corgiboygsj merged commit 5bb860f into master Mar 11, 2022
@corgiboygsj corgiboygsj deleted the fix-task-status branch March 11, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants