Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent deploy script from being executed multi times #175

Merged
merged 1 commit into from
Nov 20, 2018

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Nov 6, 2018

fix #10

Change-Id: Ife6d5e7960d4e2abdc05e7b432b0c322299f6bba

@javeme javeme force-pushed the travis-deploy-bug-rebase branch 2 times, most recently from 0a096ce to bfc38ec Compare November 8, 2018 15:57
Linary
Linary previously approved these changes Nov 15, 2018
@javeme javeme force-pushed the travis-deploy-bug-rebase branch 2 times, most recently from 2ff7f5f to 18d235f Compare November 19, 2018 06:51
@javeme javeme changed the title fix run deploy multiple times prevent deploy script from being executed multi times Nov 19, 2018
@javeme
Copy link
Contributor Author

javeme commented Nov 19, 2018

This won't work: branch =~ env(RELEASE_BRANCH) , because TRAVIS_BRANCH is the same as the tag name, see travis-ci/travis-ci#4745

https://docs.travis-ci.com/user/build-stages/#how-do-build-stages-work
https://docs.travis-ci.com/user/conditions-v1
https://docs.travis-ci.com/user/environment-variables/

Any tag starting with "v" will be considered a release version.

@javeme javeme force-pushed the travis-deploy-bug-rebase branch from 18d235f to 70c7f50 Compare November 19, 2018 08:51
1.increase a stage to deploy to prevent multi times deployment
2.integrate tinkerpop test and unit test

fix #10

Change-Id: Ife6d5e7960d4e2abdc05e7b432b0c322299f6bba
@javeme javeme force-pushed the travis-deploy-bug-rebase branch from 70c7f50 to 1e2c820 Compare November 19, 2018 12:10
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@8f3b9b5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #175   +/-   ##
=======================================
  Coverage          ?     0%           
=======================================
  Files             ?     46           
  Lines             ?   8494           
  Branches          ?    154           
=======================================
  Hits              ?      0           
  Misses            ?   8494           
  Partials          ?      0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f3b9b5...1e2c820. Read the comment docs.

@javeme javeme added the ci-cd Build or deploy label Nov 20, 2018
@zhoney zhoney merged commit 94dc821 into master Nov 20, 2018
@zhoney zhoney deleted the travis-deploy-bug-rebase branch November 20, 2018 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Build or deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The travis deployment is run multiple times due to matrix
3 participants