improve CachedGraphTransaction perf #1743
Conversation
Change-Id: I9f60f68d2faedb099e89adc2b1c1f4948d177a40
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
============================================
+ Coverage 70.78% 70.85% +0.06%
- Complexity 970 972 +2
============================================
Files 443 443
Lines 37704 37729 +25
Branches 5370 5378 +8
============================================
+ Hits 26689 26731 +42
+ Misses 8318 8293 -25
- Partials 2697 2705 +8
Continue to review full report at Codecov.
|
| @@ -111,6 +111,8 @@ private void tick(String name, Cache<Id, Object> cache) { | |||
| public <V> Cache<Id, V> cache(String name, long capacity) { | |||
| if (!this.caches.containsKey(name)) { | |||
| this.caches.putIfAbsent(name, new RamCache(capacity)); | |||
| LOG.info("Init RamCache for '{}' with capacity {}", | |||
There was a problem hiding this comment.
shall we use info for it (or use debug) ? like the first time fulfill cache
and RamCache seems not clearly compare to OffHeapCache? (level cache also have this problem)
There was a problem hiding this comment.
This is not a frequent action, and just log for 3 cache entrances(cache/offheapCache/levelCache).
RamCache may be renamed HeapCache in the future.
There was a problem hiding this comment.
OK, use HeapCache or InHeapCache is more readable
Change-Id: I9f60f68d2faedb099e89adc2b1c1f4948d177a40