Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump up rocksdb version to 6.22 #1742

Merged
merged 6 commits into from
Jun 7, 2022
Merged

bump up rocksdb version to 6.22 #1742

merged 6 commits into from
Jun 7, 2022

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Jan 26, 2022

Change-Id: I357f0c2ced0c63d1e357b52f7397fb936255b411

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #1742 (3a5aebb) into master (88d71e7) will increase coverage by 4.37%.
The diff coverage is 83.33%.

@@             Coverage Diff              @@
##             master    #1742      +/-   ##
============================================
+ Coverage     66.75%   71.12%   +4.37%     
- Complexity      728      964     +236     
============================================
  Files           451      452       +1     
  Lines         38207    38520     +313     
  Branches       5407     5421      +14     
============================================
+ Hits          25505    27399    +1894     
+ Misses        10185     8459    -1726     
- Partials       2517     2662     +145     
Impacted Files Coverage Δ
...raph/backend/store/rocksdb/RocksDBStdSessions.java 75.64% <65.67%> (+4.61%) ⬆️
...ugegraph/backend/store/rocksdb/RocksDBOptions.java 99.50% <100.00%> (+0.24%) ⬆️
...java/com/baidu/hugegraph/backend/LocalCounter.java 58.62% <0.00%> (-10.35%) ⬇️
...u/hugegraph/backend/tx/SchemaIndexTransaction.java 72.72% <0.00%> (-6.82%) ⬇️
.../backend/store/scylladb/ScyllaDBStoreProvider.java 96.15% <0.00%> (-1.15%) ⬇️
...in/java/com/baidu/hugegraph/schema/IndexLabel.java 76.13% <0.00%> (-1.14%) ⬇️
...idu/hugegraph/backend/store/mysql/MysqlTables.java 88.96% <0.00%> (-1.04%) ⬇️
...aph/backend/store/postgresql/PostgresqlTables.java 87.36% <0.00%> (-0.59%) ⬇️
...gegraph/backend/cache/CachedSchemaTransaction.java 90.33% <0.00%> (-0.49%) ⬇️
...du/hugegraph/backend/cache/CachedBackendStore.java 15.15% <0.00%> (-0.48%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88d71e7...3a5aebb. Read the comment docs.

@@ -20,7 +20,7 @@
<dependency>
<groupId>org.rocksdb</groupId>
<artifactId>rocksdbjni</artifactId>
<version>6.10.2</version>
<version>6.22.1.1</version>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: bump up to 6.30 when it's released (now 6.27.3 available, but not supports auto prefix mode and memtable whole key filtering)

rangeInt(0, Integer.MAX_VALUE),
0
);

public static final ConfigOption<Double> MEMTABLE_PREFIX_BLOOM_SIZE_RATIO =
new ConfigOption<>(
"rocksdb.memtable_prefix_bloom_size_ratio",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

@github-actions
Copy link

github-actions bot commented May 7, 2022

Due to the lack of activity, the current pr is marked as stale and will be closed after 180 days, any update will remove the stale label

javeme added 4 commits June 2, 2022 15:04

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Change-Id: I357f0c2ced0c63d1e357b52f7397fb936255b411
Change-Id: I3827d6229ce877fd251d1b0b76219318b53bb542
Change-Id: I014c5c00ee9da3103b5e31d0df52c2188cfd163e
Change-Id: I2d9d4e46f1307142e24344e9345ed957b3c8a6a3
@javeme javeme force-pushed the rocksdb-version-6.22 branch from 5c09ecb to 2f40afc Compare June 2, 2022 07:49
Change-Id: I9658101b5c855a57a824570c0925d1054c9d6f17
zyxxoo
zyxxoo previously approved these changes Jun 3, 2022
Change-Id: Id075edf08b95510fa732ace6da05a38f68088c2f
@javeme javeme merged commit bc43e5e into master Jun 7, 2022
@javeme javeme deleted the rocksdb-version-6.22 branch June 7, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants