-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cache_type default value #1681
Conversation
@@ -5,9 +5,11 @@ gremlin.graph=com.baidu.hugegraph.HugeFactory | |||
# cache config | |||
#schema.cache_capacity=100000 | |||
# vertex-cache default is 1000w, 10min expired | |||
vertex.cache_type=L2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect l2(lowercase, not L2)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,code has been updated and resubmitted
@@ -522,7 +522,7 @@ public static synchronized CoreOptions instance() { | |||
"vertex.cache_type", | |||
"The type of vertex cache, allowed values are [l1, l2].", | |||
allowValues("l1", "l2"), | |||
"l1" | |||
"l2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can also add some performance comparison results?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #1681 +/- ##
============================================
+ Coverage 66.20% 66.75% +0.55%
- Complexity 7022 7053 +31
============================================
Files 421 420 -1
Lines 34682 34668 -14
Branches 4804 4805 +1
============================================
+ Hits 22960 23143 +183
+ Misses 9379 9187 -192
+ Partials 2343 2338 -5
Continue to review full report at Codecov.
|
there is ci error:
|
No description provided.