refactor olap property #1675
Merged
refactor olap property #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I137a42916eeee00775eafb55ee299a8a64e21671
Codecov Report
@@ Coverage Diff @@
## master #1675 +/- ##
============================================
+ Coverage 66.60% 66.61% +0.01%
+ Complexity 7042 7041 -1
============================================
Files 421 420 -1
Lines 34673 34649 -24
Branches 4803 4803
============================================
- Hits 23095 23083 -12
+ Misses 9231 9222 -9
+ Partials 2347 2344 -3
Continue to review full report at Codecov.
|
zhoney
previously approved these changes
Dec 2, 2021
imbajin
reviewed
Dec 2, 2021
| @@ -258,8 +258,13 @@ public void serverStarted(Id serverId, NodeRole serverRole) { | |||
| serverId, serverRole, this.name); | |||
| this.serverInfoManager().initServerInfo(serverId, serverRole); | |||
|
|
|||
| LOG.info("Search olap property key for graph '{}'", this.name); | |||
| this.schemaTransaction().initAndRegisterOlapTables(); | |||
| // TODO: check necessary? | |||
There was a problem hiding this comment.
we will rebuild missing olap table here (in another pr)
There was a problem hiding this comment.
Ok, when will the table be missing?
There was a problem hiding this comment.
at least 2 cases:
- create property key success, create table failed (with any reason)
- the olap table store file delete/broken by some operations
and once it happens, we can't delete or search or recovery it, this problem will be fixed in that pr
| LOG.info("Search olap property key for graph '{}'", this.name); | ||
| this.schemaTransaction().initAndRegisterOlapTables(); | ||
| // TODO: check necessary? | ||
| LOG.info("Init olap property-keys for graph '{}'", this.name); |
There was a problem hiding this comment.
seems the info is not accurate, "Check olap property-keys and tables for xxx" is better
Change-Id: Idb95736c9750e771d924a44fb24d0163a647dc7b
imbajin
approved these changes
Dec 2, 2021
zhoney
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I137a42916eeee00775eafb55ee299a8a64e21671