fix: mysql & pg ci problem #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 80666c4.
Codecov Report
@@ Coverage Diff @@
## master #1641 +/- ##
============================================
+ Coverage 63.20% 66.93% +3.72%
- Complexity 6756 7063 +307
============================================
Files 421 421
Lines 34642 34645 +3
Branches 4797 4798 +1
============================================
+ Hits 21897 23188 +1291
+ Misses 10475 9113 -1362
- Partials 2270 2344 +74
Continue to review full report at Codecov.
|
javeme
approved these changes
Nov 10, 2021
corgiboygsj
approved these changes
Nov 10, 2021
javeme
reviewed
Nov 25, 2021
| @@ -49,6 +50,19 @@ jobs: | |||
| run: | | |||
| $TRAVIS_DIR/install-backend.sh ${{ matrix.BACKEND }} | |||
|
|
|||
| - name: Init Mysql Env | |||
There was a problem hiding this comment.
can we init mysql only if necessary?
There was a problem hiding this comment.
yep, can only init it when backend is mysql (better init it in install-mysql-docker.sh, but it doesn't work well)
Comment on lines
+63
to
+65
| #mysql user: 'root' # Required if "mysql root password" is empty, default is empty. The superuser for the specified database. Can use secrets, too | ||
| #mysql password: ${{ secrets.DatabasePassword }} # Required if "mysql user" exists. The password for the "mysql user" | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1634, main problems: