-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed token expire #1625
fixed token expire #1625
Conversation
guoyonggang seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@@ -667,7 +667,8 @@ public String loginUser(String username, String password) | |||
username, | |||
AuthConstant.TOKEN_USER_ID, | |||
user.id.asString()); | |||
String token = this.tokenGenerator.create(payload, this.tokenExpire); | |||
String token = this.tokenGenerator.create(payload, | |||
this.tokenExpire * 1000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can convert into ms at tokenExpire assignment: this.tokenExpire = value_from_conf * 1000
(at line 90)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Codecov Report
@@ Coverage Diff @@
## master #1625 +/- ##
============================================
- Coverage 63.26% 63.23% -0.04%
+ Complexity 6703 6701 -2
============================================
Files 418 418
Lines 34454 34454
Branches 4764 4764
============================================
- Hits 21799 21787 -12
- Misses 10407 10421 +14
+ Partials 2248 2246 -2
Continue to review full report at Codecov.
|
No description provided.