refact(core): support Infinity & NaN number in float/double property #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. due to this, float support the value > Float.MAX (trate as Infinity), so as the double 2. add test case in client (later) PS: Shall we delete old test cases directly
Codecov Report
@@ Coverage Diff @@
## master #1578 +/- ##
============================================
+ Coverage 63.26% 63.28% +0.02%
- Complexity 6703 6704 +1
============================================
Files 418 418
Lines 34449 34449
Branches 4765 4764 -1
============================================
+ Hits 21793 21800 +7
+ Misses 10407 10402 -5
+ Partials 2249 2247 -2
Continue to review full report at Codecov.
|
imbajin
changed the title
javeme
reviewed
Aug 19, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/DataType.java
Outdated
Show resolved
Hide resolved
| @@ -462,13 +467,13 @@ public void testTypeFloat() { | |||
| 1f, 3f, 3f, 127f, 128f)); | |||
|
|
|||
| Assert.assertThrows(IllegalArgumentException.class, () -> { | |||
| property("float", Double.MAX_VALUE); | |||
| property("float", 'a'); | |||
There was a problem hiding this comment.
what's the behavior of property("float", Double.MAX_VALUE)? can also test it
There was a problem hiding this comment.
treat as Infinity. add a assertEquals for it
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Outdated
Show resolved
Hide resolved
hugegraph-test/src/main/java/com/baidu/hugegraph/core/VertexCoreTest.java
Outdated
Show resolved
Hide resolved
javeme
previously approved these changes
Aug 20, 2021
javeme
reviewed
Aug 25, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/DataType.java
Outdated
Show resolved
Hide resolved
javeme
reviewed
Aug 25, 2021
hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/DataType.java
Outdated
Show resolved
Hide resolved
hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/DataType.java
Outdated
Show resolved
Hide resolved
javeme
approved these changes
Aug 27, 2021
zhoney
approved these changes
Sep 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1575 :
PS: Shall we delete old test cases directly