Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IdSet.contains() not override AbstractCollection.contains() #1511

Merged
merged 2 commits into from
Jun 24, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,12 @@ public boolean isEmpty() {
return this.numberIds.isEmpty() && this.nonNumberIds.isEmpty();
}

public boolean contains(Id id) {
@Override
public boolean contains(Object object) {
if (!(object instanceof Id)) {
return false;
}
Id id = (Id) object;
if (id.type() == Id.IdType.LONG) {
return this.numberIds.contains(id.asLong());
} else {
Expand Down