Commit index updates in batch #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
previously approved these changes
Oct 30, 2018
javeme
requested changes
Oct 30, 2018
| } | ||
| } | ||
| this.rebuildIndex(HugeType.VERTEX, label, indexLabelIds, | ||
| graphTx::queryVertices); |
There was a problem hiding this comment.
call graphTx.queryVerticesFromBackend() instead
There was a problem hiding this comment.
maybe it's better to keep the original to move this code to upper layer, just check no data in graphTx
| query.eq(HugeKeys.LABEL, label); | ||
| query.limit(Query.DEFAULT_CAPACITY); | ||
|
|
||
| int i = 0; |
| } | ||
| ++counter; | ||
| } | ||
| } while (counter == Query.DEFAULT_CAPACITY); |
There was a problem hiding this comment.
assert counter <= Query.DEFAULT_CAPACITY
javeme
requested changes
Oct 31, 2018
| .job(callable); | ||
| HugeTask<?> task = builder.schedule(); | ||
|
|
||
| if (graph.configuration().get(CoreOptions.SCHEMA_SYNC_DELETION)) { |
| protected static void removeSchema(SchemaTransaction tx, | ||
| SchemaElement schema) { | ||
| try { |
There was a problem hiding this comment.
add some comments why use reflection
1. To avoid commit all together during rebuilding index, especially for Cassandra backend, which has batch limit 65535 2. Also move async codes to com.baidu.hugegraph.job package 3. fix bug that CacheManager might create more than one cache with same name fixed: #144 implemented: #82 Change-Id: I88ff4bc878bc24122f0bb6ecf9964246a083b9ab
javeme
approved these changes
Nov 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
especially for Cassandra backend, which has batch limit 65535
fixed: #144
implemented: #82
Change-Id: I88ff4bc878bc24122f0bb6ecf9964246a083b9ab