Fix forced to Double and optimization error hint for top range #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linary
requested changes
Apr 27, 2021
...src/main/java/com/baidu/hugegraph/traversal/algorithm/SingleSourceShortestPathTraverser.java
Outdated
Show resolved
Hide resolved
zyxxoo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1432 +/- ##
=========================================
Coverage 62.21% 62.22%
- Complexity 5856 5858 +2
=========================================
Files 381 381
Lines 32135 32135
Branches 4504 4504
=========================================
+ Hits 19993 19996 +3
+ Misses 10090 10089 -1
+ Partials 2052 2050 -2
Continue to review full report at Codecov.
|
zyxxoo
force-pushed
the
zy_dev
branch
2 times, most recently
from
04f3dd9 to
088d2a8
Compare
zhoney
approved these changes
Apr 28, 2021
Linary
approved these changes
Apr 28, 2021
javeme
reviewed
Apr 28, 2021
| @@ -244,7 +244,8 @@ private Ranks contributeNewLayer(List<Adjacencies> adjacencies, | |||
| public Step(HugeGraph g, Directions direction, List<String> labels, | |||
| long degree, long skipDegree, int top, int capacity) { | |||
| E.checkArgument(top > 0 && top <= MAX_TOP, | |||
| "The top of each layer can't exceed %s", MAX_TOP); | |||
| "The top of each layer must be in (0, %s]", | |||
There was a problem hiding this comment.
perfect if prompt the actual top value
| } | ||
| return edgeWeight; | ||
| } | ||
|
|
||
| private double toDouble(Object obj) { |
| return ((Number) obj).doubleValue(); | ||
| } | ||
|
|
||
| return (double) obj; |
There was a problem hiding this comment.
prefer to call NumericUtil.toNumber(obj).doubleValue()
zhoney
pushed a commit
that referenced
this pull request
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix error hit and Integer case to Double