Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix style for raft module #1423

Merged
merged 3 commits into from
Apr 23, 2021
Merged

fix style for raft module #1423

merged 3 commits into from
Apr 23, 2021

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Apr 17, 2021

Change-Id: I36cf1e0093fb34837e5c5f46ace91c38eae10a74

Change-Id: I36cf1e0093fb34837e5c5f46ace91c38eae10a74
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #1423 (0a6eb42) into master (3c9dbca) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1423   +/-   ##
=========================================
  Coverage     62.22%   62.23%           
+ Complexity     5855     5853    -2     
=========================================
  Files           381      381           
  Lines         32109    32096   -13     
  Branches       4492     4491    -1     
=========================================
- Hits          19981    19976    -5     
+ Misses        10091    10082    -9     
- Partials       2037     2038    +1     
Impacted Files Coverage Δ Complexity Δ
...hugegraph/backend/store/raft/RaftBackendStore.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...h/backend/store/raft/RaftBackendStoreProvider.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...aidu/hugegraph/backend/store/raft/RaftClosure.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...graph/backend/store/raft/RaftGroupManagerImpl.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...m/baidu/hugegraph/backend/store/raft/RaftNode.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...baidu/hugegraph/backend/store/raft/RaftResult.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
...ugegraph/backend/store/raft/RaftSharedContext.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...hugegraph/backend/store/raft/RaftStoreClosure.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...idu/hugegraph/backend/store/raft/StoreCommand.java 55.17% <0.00%> (ø) 7.00 <1.00> (ø)
.../hugegraph/backend/store/raft/StoreSerializer.java 58.73% <0.00%> (ø) 6.00 <0.00> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c9dbca...0a6eb42. Read the comment docs.

}
}

// NOTE: Jraft itself doesn't have this callback, it's added by us
@SuppressWarnings("unused")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it. Don't write misleading annotation to shield warnings

javeme added 2 commits April 19, 2021 14:29
Change-Id: Ibcd2092562c8893a4f6a1f86f727bfe4da90db83
Change-Id: I75b25240585773932602c54610e38324285c42ca
@javeme javeme merged commit 8a2dfac into master Apr 23, 2021
@javeme javeme deleted the fix-raft-style branch April 23, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants