Collection optimize for OLTP algorithm and HugeElement #1409

zhoney · 2021-03-31T02:31:06Z

No description provided.

javeme · 2021-03-31T05:24:13Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/CrosspointsAPI.java

@@ -84,6 +84,7 @@ public String get(@Context GraphManager manager,
        HugeTraverser.PathSet paths = traverser.paths(sourceId, dir, targetId,
                                                      dir, edgeLabel, depth,
                                                      degree, capacity, limit);
-        return manager.serializer(g).writePaths("crosspoints", paths, true);
+        return manager.serializer(g).writePaths("crosspoints",
+                                                paths.paths(),true);


javeme · 2021-03-31T05:25:11Z

hugegraph-core/src/main/java/com/baidu/hugegraph/backend/cache/CachedBackendStore.java

@@ -225,6 +225,12 @@ public long asLong() {
            return 0L;
        }

+        @Override
+        public int asInt() {


don't add this method, just force convert it

javeme · 2021-03-31T05:26:48Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeEdge.java

        HugeGraph graph = ownerVertex.graph();
        VertexLabel srcLabel = graph.vertexLabelOrNone(edgeLabel.sourceLabel());
        VertexLabel tgtLabel = graph.vertexLabelOrNone(edgeLabel.targetLabel());

        VertexLabel otherVertexLabel;
        if (isOutEdge) {
-            ownerVertex.correctVertexLabel(srcLabel);
+//            ownerVertex.correctVertexLabel(srcLabel);


keep the origin

javeme · 2021-03-31T05:26:53Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeEdge.java

            otherVertexLabel = tgtLabel;
        } else {
-            ownerVertex.correctVertexLabel(tgtLabel);
+//            ownerVertex.correctVertexLabel(tgtLabel);


javeme · 2021-03-31T05:31:52Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeElement.java

@@ -98,7 +100,7 @@ protected void updateToDefaultValueIfNone() {
        this.defaultValueUpdated = true;
        // Set default value if needed
        for (Id pkeyId : this.schemaLabel().properties()) {
-            if (this.properties.containsKey(pkeyId)) {
+            if (this.properties.containsKey(pkeyId.asInt())) {


add a static method numberFromId(id)

javeme · 2021-03-31T05:57:48Z

...e/src/main/java/com/baidu/hugegraph/traversal/algorithm/strategy/SingleTraverseStrategy.java

@@ -55,7 +55,7 @@ public void traverseOneLayer(Map<Id, List<Node>> vertices,

    @Override
    public Set<Path> newPathSet() {
-        return new HugeTraverser.PathSet();
+        return new HugeTraverser.PathSet().paths();


return HugeTraverser.PathSet()?

javeme · 2021-03-31T05:58:32Z

hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/CollectionImplType.java

+            case 1:
+                return JCF;
+            case 2:
+                return EC;


add case 3 for FastUtil

javeme · 2021-03-31T05:59:40Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/IdSet.java

+
+import it.unimi.dsi.fastutil.objects.ObjectOpenHashSet;
+
+public class IdSet extends HashSet<Id> {


set final and implement Set<Id>

implement Set need to implements toArray(), containsAll(), retainAll()... methods. which will be same as implemented in AbstractSet and HashSet. extends HashSet can reduce these duplicated work

javeme · 2021-03-31T06:01:16Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/IdSet.java

+
+    private static class EcLongIterator implements Iterator<Long> {
+
+        private MutableLongIterator iterator;


javeme · 2021-03-31T06:09:21Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/IdSet.java

+        ExtendableIterator<Id> iterator = new ExtendableIterator<>();
+        iterator.extend(this.nonNumberIds.iterator());
+        EcLongIterator iter = new EcLongIterator(this.numberIds.longIterator());
+        iterator.extend(new MapperIterator<>(iter, IdGenerator::of));


let EcLongIterator return Id

Linary · 2021-04-09T08:40:50Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/NeighborRankAPI.java

@@ -50,6 +45,11 @@
 import com.codahale.metrics.annotation.Timed;
 import com.fasterxml.jackson.annotation.JsonProperty;

+import static com.baidu.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_CAPACITY;


keep origin place

Linary · 2021-04-09T08:41:53Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/SameNeighborsAPI.java

@@ -47,6 +44,9 @@
 import com.baidu.hugegraph.util.Log;
 import com.codahale.metrics.annotation.Timed;

+import static com.baidu.hugegraph.traversal.algorithm.HugeTraverser.DEFAULT_DEGREE;


Linary · 2021-04-09T08:42:11Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/ShortestPathAPI.java

-import javax.ws.rs.PathParam;
-import javax.ws.rs.Produces;
-import javax.ws.rs.QueryParam;
+import javax.ws.rs.*;


don't use *

javeme · 2021-04-12T05:32:09Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+    private int accessed;
+
+    public ArrayPathsRecord(Id sourceV, Id targetV) {
+


remove empty line

javeme · 2021-04-12T05:34:46Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+        }
+    }
+
+    public static void main(String[] args) {


move to unit test

javeme · 2021-04-12T05:35:37Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+        return (Id) this.idMapping.code2Object(code);
+    }
+
+    public static class Int2IntsMap {


move out as an independent file

javeme · 2021-04-12T05:38:04Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+        private static final int CHUNK_SIZE = 10;
+
+        private IntIntHashMap offsetMap;
+        private int[] intsTable;


add some comments

javeme · 2021-04-12T05:43:30Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+        private IntIntHashMap offsetMap;
+        private int[] intsTable;
+
+        private int nextBlock;


intsTableAlloc

javeme · 2021-04-12T06:02:39Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+                    this.intsTable[position] = this.nextBlock;
+
+                    this.intsTable[this.nextBlock] = value;
+                    this.intsTable[positionIndex] = this.nextBlock + 1;


why +1, prefer define const

javeme · 2021-04-12T06:04:27Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+
+                } else {
+                    intsTable[position] = value;
+                    this.intsTable[positionIndex]++;


++this.intsTable[firstBlockPointer + SIZE_OFFSET]

javeme · 2021-04-12T06:05:59Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+                    // Update next block
+                    this.nextBlock += CHUNK_SIZE;
+
+                } else {


swap if-statement and the else code block

javeme · 2021-04-12T06:06:29Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+                this.offsetMap.put(key, this.nextBlock);
+
+                // Init first chunk
+                this.intsTable[this.nextBlock] = this.nextBlock + 3;


define const var for all the const values

javeme · 2021-04-12T06:06:43Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+        }
+
+        private boolean endOfChunk(int position) {
+            return (position + 1) % CHUNK_SIZE == 0;


javeme · 2021-04-12T06:19:50Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeElement.java

@@ -266,17 +277,18 @@ public int sizeOfSubProperties() {
    @Watched(prefix = "element")
    public <V> HugeProperty<?> setProperty(HugeProperty<V> prop) {
        if (this.properties == EMPTY_MAP) {
-            this.properties = new HashMap<>();
+            this.properties = new IntObjectHashMap<>();


can we extends IntObjectHashMap and implement Map interface

javeme · 2021-04-12T06:20:12Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeElement.java

@@ -266,17 +277,18 @@ public int sizeOfSubProperties() {
    @Watched(prefix = "element")
    public <V> HugeProperty<?> setProperty(HugeProperty<V> prop) {
        if (this.properties == EMPTY_MAP) {
-            this.properties = new HashMap<>();
+            this.properties = new IntObjectHashMap<>();


also call CollectionFactory.newIntObjectMap()

javeme · 2021-04-12T06:21:00Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeVertex.java

    }

    public void resetEdges() {
-        this.edges = InsertionOrderUtil.newSet();
+        this.edges = new FastList<>();


call CollectionFactory

javeme · 2021-04-12T06:21:11Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeVertex.java

-        if (this.edges == EMPTY_SET) {
-            this.edges = InsertionOrderUtil.newSet();
+        if (this.edges == EMPTY_LIST) {
+            this.edges = new FastList<>();


call CollectionFactory

javeme · 2021-04-12T06:24:07Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeVertex.java

+            this.edges = newSet();
+        }
+
+        public void removeEdge(HugeEdge edge) {


seem unused, remove this method

used in HugeEdge.remove()

javeme · 2021-04-12T06:50:43Z

...h-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ShortestPathRecord.java

+    private boolean foundPath;
+
+    public ShortestPathRecord(Id sourceV, Id targetV) {
+


remove empty line

javeme · 2021-04-12T06:51:45Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/PathsRecord.java

+import com.baidu.hugegraph.util.collection.ObjectIntMapping;
+import com.google.common.collect.Lists;
+
+public class PathsRecord implements Record {


is it the same function as ArrayPathsRecord

javeme · 2021-04-12T06:53:39Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Record.java

+import com.baidu.hugegraph.backend.id.Id;
+import com.baidu.hugegraph.traversal.algorithm.HugeTraverser.PathSet;
+
+public interface Record {


prefer Records

javeme · 2021-04-12T06:56:59Z

...h-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ShortestPathRecord.java

+                this.targetLayers.peek().keySet().intIterator();
+    }
+
+    public void finishOneLayer() {


seem all the subclass are the same mode, abstract it

javeme · 2021-04-12T07:00:35Z

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecord.java

+        this.sourceLayers = new Stack<>();
+        this.targetLayers = new Stack<>();
+        this.sourceLayers.push(firstSourceLayer);
+        this.targetLayers.push(firstTargetLayer);


prefer to split into two layers: fanout and source-target, and abstract source-target layer to the top of all record implement

javeme · 2021-04-12T13:47:14Z

...ph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecords.java

+    private PathSet getTargetPath(int target) {
+        return this.concatPath(this.targetLayers, target,
+                               this.targetLayers.size() - 1);
+    }


move these 2 methods to line 152

javeme · 2021-04-12T13:47:36Z

...ph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecords.java

+        return results;
+    }
+
+    private PathSet concatPath(Stack<Int2IntsMap> all, int id, int layerIndex) {


rename to linkPath

javeme · 2021-04-12T13:47:50Z

...ph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecords.java

+        return results;
+    }
+
+    private PathSet getSourcePath(int source) {


rename to linkSourcePath

javeme · 2021-04-12T13:49:48Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Int2IntsMap.java

+    private static final int CHUNK_SIZE = 10;
+    private static final int POSITION_OFFSET = 0;
+    private static final int SIZE_OFFSET = 1;
+    private static final int FIRST_CHUNK_DATA_OFFSET = 2;


prefer prefix with OFFSET_XX

javeme · 2021-04-12T13:51:32Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Int2IntsMap.java

+     *
+     */
+
+    private IntIntHashMap firstChunkMap;


chunkMap is ok

javeme · 2021-04-12T14:03:39Z

...h-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ShortestPathRecord.java

+            IntIntHashMap layer = this.targetLayers.elementAt(i);
+            value = layer.get(value);
+            ids.add(this.id(value));
+        }


also split linkSourcePath() and linkTargetPath()

javeme · 2021-04-12T14:03:50Z

...h-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ShortestPathRecord.java

+        this.currentLayer.put(target, source);
+    }
+
+    private Path getPath(int source, int target) {


also rename to concatPath()

javeme · 2021-04-12T14:04:48Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Int2IntsMap.java

+import org.eclipse.collections.api.iterator.IntIterator;
+import org.eclipse.collections.impl.map.mutable.primitive.IntIntHashMap;
+
+public class Int2IntsMap {


move to collection package

javeme · 2021-04-12T14:07:05Z

...ph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/ArrayPathsRecords.java

+import com.baidu.hugegraph.util.collection.ObjectIntMapping;
+import com.google.common.collect.Lists;
+
+public class ArrayPathsRecords implements Records {


MultiPathsPerVertexRecords or MultiPathsRecords

javeme · 2021-04-12T14:11:22Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/PathsRecords.java

+import com.baidu.hugegraph.util.collection.ObjectIntMapping;
+import com.google.common.collect.Lists;
+
+public class PathsRecords implements Records {


MultiPathsBySetRecords

javeme · 2021-04-14T14:52:25Z

...graph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/IntArrayRecord.java

+
+    public class IntArrayIterator implements IntIterator {
+
+        private int[] array;


javeme · 2021-04-14T14:53:19Z

...graph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/IntArrayRecord.java

+
+public class IntArrayRecord implements Record {
+
+    private Int2IntsMap layer;


javeme · 2021-04-14T14:53:29Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/IntIntRecord.java

+
+public class IntIntRecord implements Record {
+
+    private IntIntHashMap layer;


javeme · 2021-04-14T14:53:46Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/IntSetRecord.java

+
+public class IntSetRecord implements Record {
+
+    private IntObjectHashMap<IntHashSet> layer;


javeme · 2021-04-14T14:55:42Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Record.java

+
+import org.eclipse.collections.api.iterator.IntIterator;
+
+public interface Record {


not addressed: prefer Records

there already exists Records for multi layers. Record means one layer paths here

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/util/JsonUtilTest.java

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/CollectionFactory.java

javeme · 2021-04-14T15:21:04Z

hugegraph-core/src/main/java/com/baidu/hugegraph/type/define/CollectionImplType.java

+
+package com.baidu.hugegraph.type.define;
+
+public enum CollectionImplType implements SerialEnum {


add unit test

javeme · 2021-04-14T15:26:21Z

...ph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/MultiPathsRecords.java

+        this.sourceRecords = new Stack<>();
+        this.targetRecords = new Stack<>();
+        this.sourceRecords.push(firstSourceRecord);
+        this.targetRecords.push(firstTargetRecord);


can abstract source and target code as 2 instances(of one class)?

javeme · 2021-04-14T15:30:34Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/Int2IntsMap.java

+    public void add(int key, int value) {
+        if (this.chunkMap.containsKey(key)) {
+            int firstChunk = this.chunkMap.get(key);
+            int nextPosition = this.chunkTable[firstChunk + OFFSET_POSITION];


the meaning of position is generic, improve the variable naming to nextXxPointer.
also address other comments:
https://github.com/hugegraph/hugegraph/pull/1409/files/75b2ef6c4de64306b75d7b91d1672c32e057360b..7248e77a062d8e375f2ef85e06ec16d5b5373337#diff-c6fe21c746e89abdbac5015ba5d5b3ec346aef2dd756922bac904958cd2aabea

javeme · 2021-05-11T07:33:11Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/KneighborTraverser.java

-        return this.customizedKneighbor(source, step, maxDepth,
-                                        limit, single);
+        Traverser traverser = new Traverser(source, step, maxDepth, limit,
+                                            single);


rename to singleThread

javeme · 2021-05-11T07:33:33Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/KneighborAPI.java


-        List<HugeTraverser.Path> paths = new ArrayList<>();
+        PathSet paths = new PathSet();


also keep HugeTraverser.PathSet

javeme · 2021-05-11T07:34:25Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/KneighborTraverser.java

-        all.add(sourceV);
+        private final EdgeStep step;
+        private final long limit;
+        private final boolean single;


rename to concurrent

javeme · 2021-05-11T07:36:54Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/KneighborTraverser.java

-                                         long limit, boolean single) {
-        Set<Node> latest = newSet(single);
-        Set<Node> all = newSet(single);
+    private class Traverser {


seems unneeded to add this class, just add a method?

javeme · 2021-05-11T07:38:40Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/OltpTraverser.java

+    }
+
+    protected long traverseIds(Iterator<Id> ids, Consumer<Id> consumer,
+                               boolean single, boolean stop) {


rename single to concurrent

javeme · 2021-05-11T07:50:33Z

...core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/record/RecordFactory.java

            default:
                throw new AssertionError("Unsupported record type: " + type);
        }
+        if (!single) {


...ph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/record/SyncRecord.java

javeme · 2021-05-11T07:53:01Z

...ph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/record/SyncRecord.java

+
+    @Override
+    public int size() {
+        return this.record.size();


also synchronized

javeme · 2021-05-11T07:53:37Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/ObjectIntMapping.java

@@ -31,12 +31,12 @@
    private final IntObjectHashMap<V> int2IdMap;

    public ObjectIntMapping() {
-        this.int2IdMap = new IntObjectHashMap<>(1000000);
+        this.int2IdMap = new IntObjectHashMap<>(10000000);


define const var

javeme · 2021-05-11T07:54:03Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/ObjectIntMapping.java

    }

    @Watched
    @SuppressWarnings("unchecked")
-    public int object2Code(Object object) {
+    public synchronized int object2Code(Object object) {


always synchronized?

codecov · 2021-05-11T13:27:18Z

Codecov Report

Merging #1409 (8b8be47) into master (83f6612) will decrease coverage by 0.51%.
The diff coverage is 32.38%.

@@             Coverage Diff              @@
##             master    #1409      +/-   ##
============================================
- Coverage     64.05%   63.54%   -0.52%     
- Complexity     5882     5975      +93     
============================================
  Files           381      402      +21     
  Lines         32190    32733     +543     
  Branches       4506     4558      +52     
============================================
+ Hits          20620    20800     +180     
- Misses         9463     9810     +347     
- Partials       2107     2123      +16

Impacted Files	Coverage Δ
.../hugegraph/api/traversers/AllShortestPathsAPI.java	`0.00% <ø> (ø)`
...m/baidu/hugegraph/api/traversers/KneighborAPI.java	`0.00% <0.00%> (ø)`
...va/com/baidu/hugegraph/api/traversers/KoutAPI.java	`0.00% <0.00%> (ø)`
...a/com/baidu/hugegraph/api/traversers/PathsAPI.java	`0.00% <ø> (ø)`
...aidu/hugegraph/api/traversers/PersonalRankAPI.java	`0.00% <ø> (ø)`
...aidu/hugegraph/api/traversers/ShortestPathAPI.java	`0.00% <ø> (ø)`
...m/baidu/hugegraph/api/traversers/TraverserAPI.java	`0.00% <ø> (ø)`
...a/com/baidu/hugegraph/auth/HugeGraphAuthProxy.java	`55.95% <ø> (ø)`
...e/src/main/java/com/baidu/hugegraph/HugeGraph.java	`65.30% <ø> (ø)`
...ugegraph/backend/cache/CachedGraphTransaction.java	`84.24% <ø> (ø)`
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83f6612...8b8be47. Read the comment docs.

javeme · 2021-05-12T05:00:37Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/KoutRecords.java

@@ -34,8 +34,8 @@

    public KoutRecords(Id source,
                       RecordType type,
-                       boolean nearest, boolean single) {
-        super(source, type, nearest, single);
+                       boolean nearest, boolean concurrent) {


move "RecordType type" to the first line?

javeme · 2021-05-12T05:01:41Z

...rc/main/java/com/baidu/hugegraph/traversal/algorithm/records/SingleWayMultiPathsRecords.java

@@ -68,8 +68,8 @@ public SingleWayMultiPathsRecords(Id source, RecordType type,
        this.records = new Stack<>();
        this.records.push(firstRecord);

-        this.accessedVertices = single ? new HashSet() :
-                                ConcurrentHashMap.newKeySet();
+        this.accessedVertices = concurrent ? ConcurrentHashMap.newKeySet() :


also use primitive map

javeme · 2021-05-12T05:04:31Z

...h-core/src/main/java/com/baidu/hugegraph/util/collection/mapping/SingleObjectIntMapping.java

    }

-    @Watched
+    @PerfUtil.Watched


remove "PerfUtil."

javeme · 2021-05-12T05:04:39Z

...h-core/src/main/java/com/baidu/hugegraph/util/collection/mapping/SingleObjectIntMapping.java

@@ -55,7 +55,7 @@ public synchronized int object2Code(Object object) {
        throw new HugeException("Failed to get code for id: %s", object);
    }

-    @Watched
+    @PerfUtil.Watched


...re/src/main/java/com/baidu/hugegraph/util/collection/mapping/ConcurrentObjectIntMapping.java

...h-core/src/main/java/com/baidu/hugegraph/util/collection/mapping/SingleObjectIntMapping.java

zhoney · 2021-05-20T05:49:06Z

cache tick()

    @Override
    public long tick() {
        long expireTime = this.expire;
        if (expireTime <= 0) {
            return 0L;
        }

        int expireItems = 0;
        long current = now();
        for (Iterator<CacheNode<K, V>> it = this.nodes(); it.hasNext();) {
            CacheNode<K, V> node = it.next();
            LOG.info("expireTime: {}, current: {}, node.time(): {}, " +
                     "current-node.time(): {}, node: {}",
                     expireTime, current, node.time(), current - node.time(), node);
            if (current - node.time() > expireTime) {
                // Remove item while iterating map (it must be ConcurrentMap)
                this.remove(node.key());
                expireItems++;
            }
        }

        if (expireItems > 0) {
            LOG.info("Cache expired {} items cost {}ms (size {}, expire {}ms)",
                      expireItems, now() - current, this.size(), expireTime);
        }
        return expireItems;
    }

output when tick() run:

2021-05-20 04:04:00 241271 [cache-expirer] [INFO ] com.baidu.hugegraph.backend.cache.Cache [] - expireTime: 28000, current: 1621483440642, node.time(): 1621483412909, current-node.time(): 27733, node: fake-id

zhoney · 2021-05-20T07:55:13Z

TODO：

primitive集合的多线程加速。目前是使用synchronized的方式加锁粒度比较粗导致性能下降，后续可以采用分段加锁等方式加速
- ConcurrentObjectIntMapping
- Record
- SingleWayMultiPathsRecords.accessedVertices
改造算法使用primitive的records。目前只有shortestpath、kout、kneighbor和paths改造完成。其他算法仍需要改造。

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeVertex.java

...-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/FusiformSimilarityTraverser.java

javeme · 2021-05-20T12:41:37Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java

@@ -96,14 +103,19 @@ protected int concurrentDepth() {
        return this.graph.option(CoreOptions.OLTP_CONCURRENT_DEPTH);
    }

+    private CollectionImplType collectionImplType() {
+        return CollectionImplType.valueOf(this.graph.option(


use ConfigConvOption

javeme · 2021-05-20T12:42:29Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java

+            query.limit(limit);
+            result = new LimitIterator<>(iterators, e -> {
+                long count = query.goOffset(1L);
+                return query.reachLimit(count - 1L);


rebase master

javeme · 2021-05-20T12:54:09Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/OltpTraverser.java

+            Iterator<Edge> edges = this.edgesOfVertex(source.id(), step);
+            while (edges.hasNext()) {
+                Id target = ((HugeEdge) edges.next()).id().otherVertexId();
+                KNode kNode = new KNode(target, (KNode) source);


can use layer collection?

this method will be deleted.

...rc/main/java/com/baidu/hugegraph/traversal/algorithm/records/DoubleWayMultiPathsRecords.java

javeme · 2021-05-20T12:59:57Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/CollectionFactory.java

+
+public class CollectionFactory {
+
+    private CollectionImplType type;


rename to CollectionType

javeme · 2021-05-20T13:01:29Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeVertex.java

@@ -664,5 +679,9 @@ protected GraphTransaction tx() {
            }
            return null;
        }
+
+        private static <V> Set<V> newSet() {


move to outer class, also add newList() for HugeVertex.resetEdges()

javeme · 2021-05-20T13:04:32Z

...rc/main/java/com/baidu/hugegraph/traversal/algorithm/records/SingleWayMultiPathsRecords.java

+    }
+
+    public int size() {
+        return 0;


ensure "return 0" is expected?

hugegraph-core/src/main/java/com/baidu/hugegraph/config/CoreOptions.java

javeme · 2021-05-21T12:41:08Z

hugegraph-core/src/main/java/com/baidu/hugegraph/config/CoreOptions.java

@@ -624,12 +625,13 @@ public static synchronized CoreOptions instance() {
                    10
            );

-    public static final ConfigOption<String> OLTP_COLLECTION_IMPL_TYPE =
-            new ConfigOption<>(
+    public static final ConfigConvOption<String, CollectionType> OLTP_COLLECTION_IMPL_TYPE =


OLTP_COLLECTION_TYPE

javeme · 2021-05-21T12:41:50Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeVertex.java

@@ -232,7 +236,7 @@ public void removeEdge(HugeEdge edge) {

    public void addEdge(HugeEdge edge) {
        if (this.edges == EMPTY_LIST) {
-            this.edges = CollectionFactory.newList(CollectionImplType.EC);
+            this.edges = CollectionFactory.newList(CollectionType.EC);


call newList();

javeme · 2021-05-21T12:42:24Z

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/HugeTraverser.java

-    private CollectionImplType collectionImplType() {
-        return CollectionImplType.valueOf(this.graph.option(
-               CoreOptions.OLTP_COLLECTION_IMPL_TYPE).toUpperCase());
+    private CollectionType collectionImplType() {


collectionType

javeme · 2021-05-21T12:46:38Z

hugegraph-api/src/main/java/com/baidu/hugegraph/api/traversers/KneighborAPI.java


-        List<HugeTraverser.Path> paths = new ArrayList<>();
+        PathSet paths = new PathSet();


also use HugeTraverser.PathSet

...ph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/record/SyncRecord.java

javeme · 2021-05-21T12:54:00Z

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/util/JsonUtilTest.java

+                (int) age.id().asLong(),
+                new HugeVertexProperty<>(vertex, age, 29),
+                (int) city.id().asLong(),
+                new HugeVertexProperty<>(vertex, city, "Beijing")


let newIntObjectMap accept <Id,Property>

javeme · 2021-05-21T13:02:13Z

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/util/JsonUtilTest.java

+                (int) date.id().asLong(),
+                new HugeEdgeProperty<>(edge, date, Utils.date("2019-03-12")),
+                (int) weight.id().asLong(),
+                new HugeEdgeProperty<>(edge, weight, 0.8)


javeme · 2021-05-21T15:46:13Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/CollectionFactory.java

+        E.checkArgument(objects.length % 2 == 0,
+                        "Must provide even arguments for " +
+                        "CollectionFactory.newIntObjectMap");
+        for (int i = 0; i < objects.length; i+=2) {


not addressed: i += 2

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/CollectionFactory.java

javeme · 2021-05-21T15:56:48Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/Int2IntsMap.java

+
+
+    /*
+     *  chunkMap         chunkTable


add some spaces before chunkTable to align with the following table

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/Int2IntsMap.java

hugegraph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/Records.java

javeme · 2021-05-21T17:36:10Z

...ore/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/record/IntArrayRecord.java

+
+import com.baidu.hugegraph.util.collection.Int2IntsMap;
+
+public class IntArrayRecord implements Record {


Int2ArrayRecord

javeme · 2021-05-21T17:36:27Z

...-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/record/IntIntRecord.java

+
+import org.eclipse.collections.impl.map.mutable.primitive.IntIntHashMap;
+
+public class IntIntRecord implements Record {


Int2IntRecord

javeme · 2021-05-21T17:37:40Z

...-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/record/IntSetRecord.java

+import org.eclipse.collections.impl.map.mutable.primitive.IntObjectHashMap;
+import org.eclipse.collections.impl.set.mutable.primitive.IntHashSet;
+
+public class IntSetRecord implements Record {


Int2SetRecord

javeme · 2021-05-21T17:40:40Z

...rc/main/java/com/baidu/hugegraph/traversal/algorithm/records/DoubleWayMultiPathsRecords.java

+import com.baidu.hugegraph.traversal.algorithm.records.record.RecordType;
+import com.google.common.collect.Lists;
+
+public class DoubleWayMultiPathsRecords extends AbstractRecords {


set abstract?

javeme · 2021-05-24T12:53:27Z

...rc/main/java/com/baidu/hugegraph/traversal/algorithm/records/SingleWayMultiPathsRecords.java

@@ -46,7 +46,7 @@
    protected final Stack<Record> records;

    private final boolean nearest;
-    private final MutableIntSet accessedVertices;
+    protected final MutableIntSet accessedVertices;


keep k-out and k-neighbor consistent

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/CollectionFactory.java

javeme · 2021-05-25T08:16:20Z

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/UnitTestSuite.java

@@ -107,6 +108,7 @@
    PageStateTest.class,
    Int2IntsMapTest.class,
    ObjectIntMappingTest.class,
+    IdSet.class,


javeme · 2021-05-25T08:19:33Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/CollectionFactory.java

+        E.checkArgument(objects.length % 2 == 0,
+                        "Must provide even arguments for " +
+                        "CollectionFactory.newIntObjectMap");
+        for (int i = 0; i < objects.length; i+=2) {


not addressed: i += 2

javeme · 2021-05-25T08:20:04Z

hugegraph-core/src/main/java/com/baidu/hugegraph/util/collection/CollectionFactory.java

+                                                  (int) key2.asLong(), value2);
+    }
+
+    public static <V> MutableIntObjectMap<V> newIntObjectMap(


can remove this version method

javeme · 2021-05-25T08:22:46Z

...rc/main/java/com/baidu/hugegraph/traversal/algorithm/records/DoubleWayMultiPathsRecords.java

+    protected Record currentRecord;
+    private IntIterator lastRecordKeys;
+    protected int current;
+    protected boolean forward;


set fields to private as possible

javeme · 2021-05-26T11:04:56Z

...rc/main/java/com/baidu/hugegraph/traversal/algorithm/records/DoubleWayMultiPathsRecords.java

    private IntIterator lastRecordKeys;
-    protected int current;
-    protected boolean forward;
+    private int current;


mean int code of currently accessed vertex's Id

...aph-core/src/main/java/com/baidu/hugegraph/traversal/algorithm/records/KneighborRecords.java

Linary · 2021-06-02T07:40:28Z

hugegraph-core/src/main/java/com/baidu/hugegraph/structure/HugeElement.java


 public abstract class HugeElement implements Element, GraphType, Idfiable {

-    private static final Map<Id, HugeProperty<?>> EMPTY_MAP = ImmutableMap.of();
+    private static final MutableIntObjectMap<HugeProperty<?>> EMPTY_MAP =
+                         new IntObjectHashMap<>();


= CollectionFactory.newIntObjectMap();

Linary · 2021-06-02T07:57:42Z

...aph-core/src/main/java/com/baidu/hugegraph/util/collection/SingleThreadObjectIntMapping.java

+    @Watched
+    @SuppressWarnings("unchecked")
+    public int object2Code(Object object) {
+        int key = object.hashCode();


key -> code

...aph-core/src/main/java/com/baidu/hugegraph/util/collection/SingleThreadObjectIntMapping.java

Linary · 2021-06-02T08:04:03Z

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/Int2IntsMapTest.java

+                               263,264,265,266,267,268,269};
+        results[4] = new int[]{270,271,272,273,274,275,276,277,278,279,
+                               280,281,282,283,284,285,286,287,288,289,
+                               290, 291,292,293,294,295,296,297,298,299};


290, 291 -> 290,291

Linary · 2021-06-02T08:04:57Z

hugegraph-test/src/main/java/com/baidu/hugegraph/unit/core/Int2IntsMapTest.java

+
+        for (int ii = 0; ii < 5; ii++) {
+            int[] result = map.getValues(ii + 1);
+            Assert.assertTrue(Arrays.equals(results[ii], result));


Assert.assertArrayEquals(results[ii], result);

...aph-core/src/main/java/com/baidu/hugegraph/util/collection/SingleThreadObjectIntMapping.java

Change-Id: I6c13f504986183804f4c7ae45a5f4e0e6099125b

Change-Id: Ie8b79a4c05696f1842476bd74d82b75fba4925a1

Change-Id: I7509a653ad429d329165e968358cf4d01bf86742

Change-Id: I4b79d0987f1eebcfb952bc4627a2f4fc8d2dcaf3

Change-Id: Iffad898d0ff04f8b8937eb774352c853bae87aef

Change-Id: I0791e3d307f2cff51ccc4760ea63c52468a4b8d8

Change-Id: I9e5926333dc6ad12fd081695e37994d77f26faab

Change-Id: I761abfa4940ebaa1dd331e9c60c80293bea5d2cb

Change-Id: Ib653623d5cc79696f58ec50ccadca8ac7039c2f1

Change-Id: I742ce92cea71f556d0c7b5a52229e46006f759e7

Change-Id: Ia6a8e3316c40ecf44f6f36c4cfee50db2f7d11fe

Change-Id: I9588f2df9a6db197dcd0d35c98b7d99993a9aabf

Change-Id: I1358fb9216dd2a8d04be0e8772cd715c79c61b1e

Change-Id: Icb18c665b27dced23415bdcfc582fa372d1fe2ba

Change-Id: I5ca0ed20f0bba31226aeb10e22d191bc970e6805

Change-Id: I40b3e2c5b3d66206045ce6842e2a85ad2907bcdd

Change-Id: Ieb9a8bb4a0c2e7c6f2f18f8745783c93e51754cf

Change-Id: I1a66e5ea99a32f6cead79b80317dc7d7b3a77fa7

Change-Id: I80bd3d4ae961794cc82139262d605fe400f8c28b

Change-Id: I14abe49850d42f34576c6d1837ed5b620ffbda21

Change-Id: I580df88f57302dfe474108a93108759e33e083e2

* add Eclipse Collection dependency * use primitive map for properties of HugeElement * from Map<Id, HugeProperty<?>> to MutableIntObjectMap<HugeProperty<?>> * allow config oltp collections(JCF or EC) * add fastutil choice for collection * change Set<HugeEdge> of HugeVertex to List<HugeEdge> * use IntObjectMap and IntIntMap to improve shortest path * improve paths api by remove redundant sourcesAll and targetsAll * improve paths api performance by using IntObjectHashMap<IntHashSet> * extract shortestpath and paths record to hold traversed paths * implement Int2IntsMap for array paths record * extract Record and Records for paths and shortest path * adapt primitive collection for kout/kneighbor * add objectintmapping unit test * add UT for CollectionFactory and IdSet Change-Id: I501a18a70054fad3c40bd6b9e852a82a5c185949

javeme requested changes Mar 31, 2021

View reviewed changes

zhoney force-pushed the collection-optimize branch from 97d3f65 to cdc64f4 Compare April 7, 2021 13:11

Linary requested changes Apr 9, 2021

View reviewed changes

javeme requested changes Apr 12, 2021

View reviewed changes

javeme reviewed Apr 12, 2021

View reviewed changes

javeme reviewed Apr 14, 2021

View reviewed changes

zhoney force-pushed the collection-optimize branch from 7456243 to 5b56077 Compare May 10, 2021 12:07

javeme reviewed May 11, 2021

View reviewed changes

javeme reviewed May 12, 2021

View reviewed changes

zhoney force-pushed the collection-optimize branch from 3a51a42 to be0eaea Compare May 12, 2021 07:27

zhoney force-pushed the collection-optimize branch from 1ae39a7 to 4889059 Compare May 20, 2021 08:08

javeme reviewed May 20, 2021

View reviewed changes

zhoney force-pushed the collection-optimize branch from 4889059 to 224d26b Compare May 21, 2021 04:02

javeme reviewed May 21, 2021

View reviewed changes

zhoney force-pushed the collection-optimize branch from 224d26b to b3969e4 Compare May 21, 2021 13:08

javeme reviewed May 21, 2021

View reviewed changes

javeme requested changes May 24, 2021

View reviewed changes

javeme reviewed May 25, 2021

View reviewed changes

javeme reviewed May 26, 2021

View reviewed changes

zhoney force-pushed the collection-optimize branch 2 times, most recently from f400213 to 4392dcb Compare May 28, 2021 07:57

Linary requested changes Jun 3, 2021

View reviewed changes

zhoney force-pushed the collection-optimize branch from 4392dcb to 8427bdf Compare June 3, 2021 09:56

Linary previously approved these changes Jun 4, 2021

View reviewed changes

javeme reviewed Jun 5, 2021

View reviewed changes

zhoney added 21 commits June 8, 2021 14:18

improve

e4dac48

Change-Id: I6c13f504986183804f4c7ae45a5f4e0e6099125b

improve

affd1a5

Change-Id: Ie8b79a4c05696f1842476bd74d82b75fba4925a1

improve

4234458

Change-Id: I7509a653ad429d329165e968358cf4d01bf86742

extract Record and Records for paths and shortest path

fca1551

Change-Id: I4b79d0987f1eebcfb952bc4627a2f4fc8d2dcaf3

adapt primitive collection for kout/kneighbor

8d9e3c3

Change-Id: Iffad898d0ff04f8b8937eb774352c853bae87aef

multiple threads adapt for kout/kneighbor

35a7bc7

Change-Id: I0791e3d307f2cff51ccc4760ea63c52468a4b8d8

improve

2501070

Change-Id: I9e5926333dc6ad12fd081695e37994d77f26faab

improve

9b71bd5

Change-Id: I761abfa4940ebaa1dd331e9c60c80293bea5d2cb

add objectintmapping unit test

fe483c7

Change-Id: Ib653623d5cc79696f58ec50ccadca8ac7039c2f1

improve

00d5741

Change-Id: I742ce92cea71f556d0c7b5a52229e46006f759e7

add some LOG info for debug

bc74387

Change-Id: Ia6a8e3316c40ecf44f6f36c4cfee50db2f7d11fe

reduce expire time for CacheManagerTest.testCacheExpire()

bb0d39d

Change-Id: I9588f2df9a6db197dcd0d35c98b7d99993a9aabf

remove debug LOG info

448325c

Change-Id: I1358fb9216dd2a8d04be0e8772cd715c79c61b1e

improve

0ac67e9

Change-Id: Icb18c665b27dced23415bdcfc582fa372d1fe2ba

improve

a4d32bf

Change-Id: I5ca0ed20f0bba31226aeb10e22d191bc970e6805

improve

5073a0b

Change-Id: I40b3e2c5b3d66206045ce6842e2a85ad2907bcdd

improve

0a42055

Change-Id: Ieb9a8bb4a0c2e7c6f2f18f8745783c93e51754cf

improve

3107bba

Change-Id: I1a66e5ea99a32f6cead79b80317dc7d7b3a77fa7

improve

ff5b60e

Change-Id: I80bd3d4ae961794cc82139262d605fe400f8c28b

improve

d9b3300

Change-Id: I14abe49850d42f34576c6d1837ed5b620ffbda21

add UT for CollectionFactory and IdSet

8b8be47

Change-Id: I580df88f57302dfe474108a93108759e33e083e2

zhoney dismissed Linary’s stale review via 8b8be47 June 8, 2021 08:33

zhoney force-pushed the collection-optimize branch from 8427bdf to 8b8be47 Compare June 8, 2021 08:33

javeme approved these changes Jun 9, 2021

View reviewed changes

Linary approved these changes Jun 9, 2021

View reviewed changes

zhoney merged commit 23e3c31 into master Jun 9, 2021

zhoney deleted the collection-optimize branch June 9, 2021 09:36

javeme mentioned this pull request Nov 9, 2021

[Feature] primitive collection adaptation #1636

Open


		import it.unimi.dsi.fastutil.objects.ObjectOpenHashSet;

		public class IdSet extends HashSet<Id> {


		private static class EcLongIterator implements Iterator<Long> {

		private MutableLongIterator iterator;

		private int accessed;

		public ArrayPathsRecord(Id sourceV, Id targetV) {

		private boolean foundPath;

		public ShortestPathRecord(Id sourceV, Id targetV) {


		public class IntArrayIterator implements IntIterator {

		private int[] array;


		public class IntArrayRecord implements Record {

		private Int2IntsMap layer;


		public class IntIntRecord implements Record {

		private IntIntHashMap layer;


		public class IntSetRecord implements Record {

		private IntObjectHashMap<IntHashSet> layer;


		import org.eclipse.collections.api.iterator.IntIterator;

		public interface Record {


		package com.baidu.hugegraph.type.define;

		public enum CollectionImplType implements SerialEnum {


		List<HugeTraverser.Path> paths = new ArrayList<>();
		PathSet paths = new PathSet();


		public class CollectionFactory {

		private CollectionImplType type;


		import com.baidu.hugegraph.util.collection.Int2IntsMap;

		public class IntArrayRecord implements Record {


		import org.eclipse.collections.impl.map.mutable.primitive.IntIntHashMap;

		public class IntIntRecord implements Record {

Collection optimize for OLTP algorithm and HugeElement #1409

Collection optimize for OLTP algorithm and HugeElement #1409

Conversation

zhoney commented Mar 31, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented May 11, 2021 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhoney commented May 20, 2021 • edited Loading

zhoney commented May 20, 2021 • edited Loading

Choose a reason for hiding this comment

codecov bot commented May 11, 2021 •

edited

Loading

zhoney commented May 20, 2021 •

edited

Loading

zhoney commented May 20, 2021 •

edited

Loading