Fix inappropriate shard will cause base64 decode error #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ibc90df4e792b00222d41806fee769082545dea40
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
============================================
- Coverage 62.37% 62.09% -0.29%
- Complexity 5829 5842 +13
============================================
Files 385 385
Lines 31953 32260 +307
Branches 4460 4521 +61
============================================
+ Hits 19931 20032 +101
- Misses 10001 10199 +198
- Partials 2021 2029 +8 Continue to review full report at Codecov.
|
javeme
reviewed
Mar 9, 2021
| @@ -327,6 +327,7 @@ public long estimateNumKeys(Session session) { | |||
|
|
|||
| @Override | |||
| public byte[] position(String position) { | |||
| // The value of START AND END are same | |||
There was a problem hiding this comment.
AND => and
but prefer don't assume START and END are the same, prefer START.equals(position) || END.equals(position)
Linary
changed the title
Change-Id: Ia21bb0bcbbca9c3110f6c6ad61c15f4a2f598b1c
javeme
approved these changes
Mar 10, 2021
Linary
changed the title
zhoney
approved these changes
Mar 11, 2021
javeme
pushed a commit
that referenced
this pull request
Mar 29, 2021
* Fix shard start is 0 will cause base64 decode error Change-Id: Ibc90df4e792b00222d41806fee769082545dea40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.