Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: add resource metrics_read #1355

Merged
merged 5 commits into from
Feb 8, 2021
Merged

auth: add resource metrics_read #1355

merged 5 commits into from
Feb 8, 2021

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Feb 5, 2021

Change-Id: Iba110199addbfae220616ed69754dcac82fbc848

Change-Id: Iba110199addbfae220616ed69754dcac82fbc848
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1355 (a20ff5f) into master (7e480e6) will increase coverage by 0.00%.
The diff coverage is 18.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1355   +/-   ##
=========================================
  Coverage     62.48%   62.49%           
+ Complexity     5816     5815    -1     
=========================================
  Files           379      379           
  Lines         31771    31766    -5     
  Branches       4447     4443    -4     
=========================================
- Hits          19853    19852    -1     
+ Misses         9901     9895    -6     
- Partials       2017     2019    +2     
Impacted Files Coverage Δ Complexity Δ
...va/com/baidu/hugegraph/api/metrics/MetricsAPI.java 65.78% <ø> (ø) 0.00 <0.00> (ø)
...com/baidu/hugegraph/auth/HugeFactoryAuthProxy.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...va/com/baidu/hugegraph/auth/HugeAuthenticator.java 20.32% <28.12%> (+1.24%) 0.00 <0.00> (ø)
...src/main/java/com/baidu/hugegraph/HugeFactory.java 74.00% <66.66%> (-1.00%) 11.00 <4.00> (+1.00) ⬇️
...idu/hugegraph/api/filter/AuthenticationFilter.java 34.72% <75.00%> (ø) 0.00 <0.00> (ø)
...ava/com/baidu/hugegraph/api/profile/GraphsAPI.java 24.44% <100.00%> (ø) 0.00 <0.00> (ø)
...in/java/com/baidu/hugegraph/auth/ResourceType.java 73.17% <100.00%> (+0.67%) 15.00 <0.00> (ø)
...va/com/baidu/hugegraph/task/ServerInfoManager.java 70.78% <0.00%> (-2.25%) 51.00% <0.00%> (ø%)
...ain/java/com/baidu/hugegraph/task/TaskManager.java 71.11% <0.00%> (-1.49%) 25.00% <0.00%> (-1.00%)
...c/main/java/com/baidu/hugegraph/task/HugeTask.java 69.63% <0.00%> (-0.31%) 81.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e480e6...a20ff5f. Read the comment docs.

Change-Id: I6011952eae765650d38c9de48237e41dc888d1f6
Change-Id: I728410b9d2c280c8a4ab5ade93d75a5530c625e2
Change-Id: I3f89340a7eed83b368309fc29bc138616cf49bd1
* here is only to provide pre-control by extract the suffix of
* action {vertex/edge/schema}_{read/write} like vertex_read.
* here is only to provide pre-control by extract the
* ressource_action {vertex/edge/schema}_{read/write},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resource ?

* action {vertex/edge/schema}_{read/write} like vertex_read.
* here is only to provide pre-control by extract the
* ressource_action {vertex/edge/schema}_{read/write},
* ressource_action like vertex_read.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

*/
String ressource = action.substring(0, offset - 1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Change-Id: I6b2c13d4c8a8621d444139a91e215b9f4d227efc
@zhoney zhoney merged commit c3f81f5 into master Feb 8, 2021
@zhoney zhoney deleted the auth-add-ress-metrics_read branch February 8, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants