add config for whether encoding number of primary keys #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I07e113b7f29e0d38e5d362663046c755ea8dc751
Codecov Report
@@ Coverage Diff @@
## master #1323 +/- ##
=========================================
Coverage 62.33% 62.34%
+ Complexity 5771 5769 -2
=========================================
Files 377 377
Lines 31535 31546 +11
Branches 4418 4421 +3
=========================================
+ Hits 19658 19667 +9
- Misses 9880 9881 +1
- Partials 1997 1998 +1
Continue to review full report at Codecov.
|
javeme
reviewed
Jan 6, 2021
| @@ -200,12 +202,14 @@ public void correctVertexLabel(VertexLabel correctLabel) { | |||
| IdStrategy.PRIMARY_KEY); | |||
|
|
|||
| List<Object> propValues = new ArrayList<>(primaryKeys.size()); | |||
| boolean encodeNumber = ((HugeConfig) this.graph().configuration()).get( | |||
There was a problem hiding this comment.
don't call configuration() if enable auth
There was a problem hiding this comment.
add method graph.option(CoreOptions.VERTEX_ENCODE_PK_NUMBER) and set whitelist
|
please set related issue id |
fixed: hugegraph/hugegraph-tools #78 Change-Id: I6faab73da43c8f2ede349b109b1047c2689f2e57
javeme
requested changes
Jan 6, 2021
| @@ -547,6 +548,11 @@ public long now() { | |||
| return this.hugegraph.now(); | |||
| } | |||
|
|
|||
| @Override | |||
| public <V> V option(ConfigOption<V> option) { | |||
| return this.hugegraph.option(option); | |||
There was a problem hiding this comment.
this.verifyStatusPermission();
| @@ -270,6 +270,11 @@ public boolean existsSchemaId(HugeType type, Id id) { | |||
| return this.getSchema(type, id) != null; | |||
| } | |||
|
|
|||
| private boolean syncDelete() { | |||
There was a problem hiding this comment.
let asyncRun get it by option()
| @@ -95,7 +96,7 @@ protected void checkSchemaIdIfRestoringMode(HugeType type, Id id) { | |||
| } | |||
|
|
|||
| protected long taskWaitTimeout() { | |||
| return this.transaction.taskWaitTimeout(); | |||
| return this.graph.option(CoreOptions.TASK_WAIT_TIMEOUT); | |||
There was a problem hiding this comment.
delete taskWaitTimeout() method
| Configuration conf = HugeFeatures.this.graph.configuration(); | ||
| return ((HugeConfig) conf).get(CoreOptions.VERTEX_DEFAULT_LABEL); | ||
| return HugeFeatures.this.graph | ||
| .option(CoreOptions.VERTEX_DEFAULT_LABEL); |
| @@ -200,12 +201,14 @@ public void correctVertexLabel(VertexLabel correctLabel) { | |||
| IdStrategy.PRIMARY_KEY); | |||
|
|
|||
| List<Object> propValues = new ArrayList<>(primaryKeys.size()); | |||
| boolean encodeNumber = this.graph() | |||
| .option(CoreOptions.VERTEX_ENCODE_PK_NUMBER); | |||
| if (propertyName.equals(P.INPUT)) { | ||
| propertyLimit = this.scheduler().taskInputSizeLimit(); | ||
| propertyLimit = graph.option(CoreOptions.TASK_INPUT_SIZE_LIMIT) | ||
| .intValue(); |
There was a problem hiding this comment.
change propertyLimit to long
javeme
approved these changes
Jan 7, 2021
Linary
approved these changes
Jan 7, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix apache/incubator-hugegraph-tools#78
Change-Id: I07e113b7f29e0d38e5d362663046c755ea8dc751