Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix g.V().hasLabel().limit(n) lose some results due to overridden index #1316

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

javeme
Copy link
Contributor

@javeme javeme commented Dec 27, 2020

Change-Id: I525fd089a7bf064e8185c41e35f1104b7c50d1e2

… index

Change-Id: I525fd089a7bf064e8185c41e35f1104b7c50d1e2
@codecov
Copy link

codecov bot commented Dec 27, 2020

Codecov Report

Merging #1316 (6c50a8d) into master (f6c9850) will increase coverage by 0.67%.
The diff coverage is 82.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1316      +/-   ##
============================================
+ Coverage     61.67%   62.35%   +0.67%     
- Complexity     5752     5771      +19     
============================================
  Files           377      377              
  Lines         31501    31525      +24     
  Branches       4413     4417       +4     
============================================
+ Hits          19428    19657     +229     
+ Misses        10088     9873     -215     
- Partials       1985     1995      +10     
Impacted Files Coverage Δ Complexity Δ
.../java/com/baidu/hugegraph/backend/query/Query.java 85.04% <ø> (ø) 110.00 <0.00> (ø)
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 80.12% <82.35%> (-0.07%) 306.00 <4.00> (-1.00)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 81.34% <100.00%> (+0.02%) 203.00 <0.00> (ø)
...a/com/baidu/hugegraph/backend/query/Condition.java 78.75% <0.00%> (+0.36%) 32.00% <0.00%> (ø%)
.../baidu/hugegraph/backend/query/ConditionQuery.java 86.40% <0.00%> (+0.40%) 106.00% <0.00%> (+1.00%)
.../backend/store/cassandra/CassandraSessionPool.java 57.14% <0.00%> (+1.02%) 11.00% <0.00%> (ø%)
...om/baidu/hugegraph/backend/store/BackendTable.java 73.33% <0.00%> (+48.50%) 11.00% <0.00%> (ø%)
...h/backend/store/scylladb/ScyllaDBTablesWithMV.java 96.03% <0.00%> (+96.03%) 10.00% <0.00%> (+10.00%)
...graph/backend/store/scylladb/ScyllaDBFeatures.java 100.00% <0.00%> (+100.00%) 3.00% <0.00%> (+3.00%)
.../backend/store/scylladb/ScyllaDBStoreProvider.java 100.00% <0.00%> (+100.00%) 7.00% <0.00%> (+7.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c9850...6c50a8d. Read the comment docs.

@zhoney zhoney merged commit af2590f into master Jan 4, 2021
@zhoney zhoney deleted the label-query-offset-limit-bug branch January 4, 2021 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants