improve tx-cache and index&ids query #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javeme
force-pushed
the
tx-cache-improve-rebase
branch
from
eb73b91 to
daa7eee
Compare
|
need rebase |
javeme
force-pushed
the
tx-cache-improve-rebase
branch
2 times, most recently
from
cc076b2 to
8d6d57f
Compare
Linary
reviewed
Nov 1, 2018
| private Collection<Id> intersectIndexQueries(IndexQueries queries) { | ||
| Collection<Id> intersectIds = null; | ||
|
|
||
| for (Map.Entry<IndexLabel, ConditionQuery> entry: queries.entrySet()) { |
There was a problem hiding this comment.
add a space between 'entry' and ':'
Linary
requested changes
Nov 1, 2018
| } | ||
| if (vertices.isEmpty()) { |
There was a problem hiding this comment.
seems no need to set 'newQuery = query'
javeme
force-pushed
the
tx-cache-improve-rebase
branch
3 times, most recently
from
e2b03a6 to
c608611
Compare
Linary
requested changes
Nov 15, 2018
| // TODO: Use a more precise strategy to update the edge cache | ||
| this.edgesCache.clear(); | ||
| public void commit() throws BackendException { | ||
| if (!this.edgesInTx().isEmpty()) { |
There was a problem hiding this comment.
add a method to judge 'this.addedEdges, this.removedEdges and this.updatedEdges' is empty
javeme
force-pushed
the
tx-cache-improve-rebase
branch
2 times, most recently
from
5cc2d6f to
a6e932d
Compare
javeme
changed the title
changes: * ensure return duplicate records when querying by ids * tx cache override queryVerticesFromBackend() method * remove CacheTx.rollback() and addXX()/removeXX() methods since won't cache uncommitted records queried from tx fix #160 Change-Id: Ib0116f2faf0d0da9ec40ea335c87950e1c6e7276
javeme
force-pushed
the
tx-cache-improve-rebase
branch
from
a6e932d to
6d6fff3
Compare
Linary
approved these changes
Nov 19, 2018
zhoney
approved these changes
Nov 19, 2018
VGalaxies
pushed a commit
that referenced
this pull request
Aug 3, 2024
* refact: clean code & typo & update the name of getTimeZone Typo: getTimeZome() -> getTimeZone() And we need check/update the class used it later * Update RestClient.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ib0116f2faf0d0da9ec40ea335c87950e1c6e7276