minor improve

apache · Oct 23, 2024 · c9822eb · c9822eb
1 parent 7b6fdea
commit c9822eb
Show file tree

Hide file tree

Showing 40 changed files with 882 additions and 709 deletions.
diff --git a/hugegraph-store/hg-store-client/src/main/java/org/apache/hugegraph/store/HgKvStore.java b/hugegraph-store/hg-store-client/src/main/java/org/apache/hugegraph/store/HgKvStore.java
@@ -22,9 +22,6 @@
 import org.apache.hugegraph.store.client.grpc.KvCloseableIterator;
 import org.apache.hugegraph.store.grpc.stream.ScanStreamReq;
 
-/**
- * @version 0.2.0
- */
 public interface HgKvStore {
 
     /**

diff --git a/hugegraph-store/hg-store-client/src/main/java/org/apache/hugegraph/store/HgOwnerKey.java b/hugegraph-store/hg-store-client/src/main/java/org/apache/hugegraph/store/HgOwnerKey.java
@@ -25,11 +25,6 @@
 
 import org.apache.hugegraph.store.client.util.HgStoreClientUtil;
 
-/**
- * created on 2021/10/14
- *
- * @version 1.3.0 add canceled assert
- */
 public class HgOwnerKey implements Serializable {
 
     private final byte[] owner; // TODO: consider remove? since it seems to be useless

diff --git a/hugegraph-store/hg-store-client/src/main/java/org/apache/hugegraph/store/HgScanQuery.java b/hugegraph-store/hg-store-client/src/main/java/org/apache/hugegraph/store/HgScanQuery.java
@@ -24,11 +24,6 @@
 import org.apache.hugegraph.store.client.util.HgAssert;
 import org.apache.hugegraph.store.grpc.common.ScanOrderType;
 
-/**
- * 2022/3/4
- *
- * @version 0.5.0
- */
 public interface HgScanQuery {
 
     static HgScanQuery tableOf(String table) {

diff --git a/...tore-client/src/main/java/org/apache/hugegraph/store/client/HgNodePartitionerBuilder.java b/...tore-client/src/main/java/org/apache/hugegraph/store/client/HgNodePartitionerBuilder.java
@@ -25,11 +25,6 @@
 
 import javax.annotation.concurrent.NotThreadSafe;
 
-/**
- * created on 2021/10/26
- *
- * @version 1.0.0
- */
 @NotThreadSafe
 public final class HgNodePartitionerBuilder {
 

diff --git a/...ph-store/hg-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNode.java b/...ph-store/hg-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNode.java
@@ -19,11 +19,6 @@
 
 import org.apache.hugegraph.store.HgStoreSession;
 
-/**
- * created on 2021/10/11
- *
- * @version 0.2.0
- */
 public interface HgStoreNode {
 
     /**

diff --git a/...e/hg-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodeManager.java b/...e/hg-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodeManager.java
@@ -35,11 +35,7 @@
 import lombok.extern.slf4j.Slf4j;
 
 /**
- * // TODO: Mapping to Store-Node-Cluster, one to one.
- * <p>
- * created on 2021/10/11
- *
- * @version 0.2.0
+ * TODO: Mapping to Store-Node-Cluster, one to one.
  */
 @ThreadSafe
 @Slf4j

diff --git a/.../hg-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodeNotifier.java b/.../hg-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodeNotifier.java
@@ -17,11 +17,6 @@
 
 package org.apache.hugegraph.store.client;
 
-/**
- * created on 2021/10/12
- *
- * @version 1.0.0
- */
 public interface HgStoreNodeNotifier {
 
     /**

diff --git a/...-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodePartitioner.java b/...-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodePartitioner.java
@@ -19,11 +19,6 @@
 
 import org.apache.hugegraph.store.client.util.HgStoreClientConst;
 
-/**
- * created on 2021/10/12
- *
- * @version 1.0.0
- */
 public interface HgStoreNodePartitioner {
 
     /**

diff --git a/...e/hg-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodeSession.java b/...e/hg-store-client/src/main/java/org/apache/hugegraph/store/client/HgStoreNodeSession.java
@@ -19,11 +19,6 @@
 
 import org.apache.hugegraph.store.HgStoreSession;
 
-/**
- * created on 2021/10/11
- *
- * @version 0.1.0
- */
 public interface HgStoreNodeSession extends HgStoreSession {
 
     /**

diff --git a/...e/hg-store-client/src/main/java/org/apache/hugegraph/store/client/NodeTxSessionProxy.java b/...e/hg-store-client/src/main/java/org/apache/hugegraph/store/client/NodeTxSessionProxy.java
@@ -56,11 +56,6 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * created on 2022/01/19
- *
- * @version 0.6.0 added batch scan on 2022/03/03
- */
 @Slf4j
 @NotThreadSafe
 class NodeTxSessionProxy implements HgStoreSession {

diff --git a/...re/hg-store-client/src/main/java/org/apache/hugegraph/store/client/SequencedIterator.java b/...re/hg-store-client/src/main/java/org/apache/hugegraph/store/client/SequencedIterator.java
@@ -29,13 +29,6 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * Proxy iterator orderly, to switch next one will happen when the current one is empty.
- * <p>
- * created on 2022/03/10
- *
- * @version 0.1.0
- */
 @Slf4j
 public class SequencedIterator implements HgKvIterator {
 

diff --git a/...-store-client/src/main/java/org/apache/hugegraph/store/client/ShiftWorkIteratorProxy.java b/...-store-client/src/main/java/org/apache/hugegraph/store/client/ShiftWorkIteratorProxy.java
@@ -28,11 +28,6 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * created on 2021/10/24
- *
- * @version 0.1.1
- */
 @Slf4j
 public class ShiftWorkIteratorProxy implements HgKvIterator {
 

diff --git a/...hg-store-client/src/main/java/org/apache/hugegraph/store/client/TopWorkIteratorProxy.java b/...hg-store-client/src/main/java/org/apache/hugegraph/store/client/TopWorkIteratorProxy.java
@@ -25,11 +25,6 @@
 import org.apache.hugegraph.store.HgKvEntry;
 import org.apache.hugegraph.store.HgKvIterator;
 
-/**
- * created on 2021/10/21
- *
- * @version 0.1.0
- */
 class TopWorkIteratorProxy implements HgKvIterator {
 
     private static final byte[] EMPTY_BYTES = new byte[0];

diff --git a/...store-client/src/main/java/org/apache/hugegraph/store/client/grpc/GrpcKvIteratorImpl.java b/...store-client/src/main/java/org/apache/hugegraph/store/client/grpc/GrpcKvIteratorImpl.java
@@ -32,11 +32,6 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * created on 2021/10/20
- *
- * @version 0.2.1
- */
 @Slf4j
 class GrpcKvIteratorImpl implements HgKvPagingIterator<HgKvEntry>, HgKvOrderedIterator<HgKvEntry> {
 

diff --git a/...client/src/main/java/org/apache/hugegraph/store/client/grpc/GrpcStoreNodeSessionImpl.java b/...client/src/main/java/org/apache/hugegraph/store/client/grpc/GrpcStoreNodeSessionImpl.java
@@ -52,11 +52,6 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * created on 2022/01/19
- *
- * @version 0.6.0 added batch get on 2022/04/06
- */
 @Slf4j
 @NotThreadSafe
 class GrpcStoreNodeSessionImpl implements HgStoreNodeSession {

diff --git a/...e-client/src/main/java/org/apache/hugegraph/store/client/grpc/GrpcStoreSessionClient.java b/...e-client/src/main/java/org/apache/hugegraph/store/client/grpc/GrpcStoreSessionClient.java
@@ -47,11 +47,6 @@
 import io.grpc.ManagedChannel;
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * created on 2021/11/18
- *
- * @version 0.5.0
- */
 @Slf4j
 @ThreadSafe
 class GrpcStoreSessionClient extends AbstractGrpcClient {

diff --git a/...re-client/src/main/java/org/apache/hugegraph/store/client/grpc/GrpcStoreStreamClient.java b/...re-client/src/main/java/org/apache/hugegraph/store/client/grpc/GrpcStoreStreamClient.java
@@ -34,11 +34,6 @@
 import io.grpc.stub.AbstractBlockingStub;
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * created on 2021/10/19
- *
- * @version 1.1.1 added synchronized in getChannel.
- */
 @Slf4j
 @ThreadSafe
 public class GrpcStoreStreamClient extends AbstractGrpcClient {

diff --git a/.../hg-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/KvBatchScanner.java b/.../hg-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/KvBatchScanner.java
@@ -46,13 +46,6 @@
 import io.grpc.stub.StreamObserver;
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * Batch streaming query client implementation class
- * <p>
- * created on 2022/07/23
- *
- * @version 3.0.0
- */
 @Slf4j
 @NotThreadSafe
 public class KvBatchScanner implements Closeable {

diff --git a/...hg-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/KvBatchScanner5.java b/...hg-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/KvBatchScanner5.java
@@ -35,7 +35,7 @@
 import org.apache.hugegraph.store.HgScanQuery;
 import org.apache.hugegraph.store.client.HgStoreNodeSession;
 import org.apache.hugegraph.store.client.type.HgStoreClientException;
-import org.apache.hugegraph.store.client.util.Base58;
+import org.apache.hugegraph.store.util.Base58Encoder;
 import org.apache.hugegraph.store.client.util.HgStoreClientConfig;
 import org.apache.hugegraph.store.grpc.common.Kv;
 import org.apache.hugegraph.store.grpc.stream.HgStoreStreamGrpc;
@@ -47,11 +47,6 @@
 import io.grpc.stub.StreamObserver;
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * created on 2022/03/23
- *
- * @version 5.0.0
- */
 @Slf4j
 @NotThreadSafe
 class KvBatchScanner5 {
@@ -107,7 +102,7 @@ private static class OrderBroker {
 
             if (log.isDebugEnabled()) {
                 if (scanQuery.getPrefixList() != null && scanQuery.getPrefixList().size() > 0) {
-                    brokerId = Base58.encode(scanQuery.getPrefixList().get(0).getKey());
+                    brokerId = Base58Encoder.convertToBase58(scanQuery.getPrefixList().get(0).getKey());
 
                     log.debug(
                             "[ANALYSIS START] [{}] firstKey: {}, keyLength: {}, table: {}, node: {}"

diff --git a/...e/hg-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/KvPageScanner.java b/...e/hg-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/KvPageScanner.java
@@ -50,11 +50,6 @@
 import io.grpc.stub.StreamObserver;
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * created on 2021/10/21
- *
- * @version 0.6.1 [email protected] on 2022/04/05
- */
 @Slf4j
 @NotThreadSafe
 class KvPageScanner implements KvCloseableIterator<Kv>, HgPageSize, HgSeekAble {

diff --git a/...-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/NotifyingExecutor.java b/...-store-client/src/main/java/org/apache/hugegraph/store/client/grpc/NotifyingExecutor.java
@@ -40,11 +40,6 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-/**
- * 2021/11/18
- *
- * @version 0.3.0 on 2022/01/27
- */
 @Slf4j
 final class NotifyingExecutor {