fix checkstyle setting issue (#1857)

apache · May 5, 2022 · c9714df · c9714df
1 parent 044a15e
commit c9714df
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -351,6 +351,13 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-checkstyle-plugin</artifactId>
                 <version>${checkstyle.version}</version>
+                <dependencies>
+                    <dependency>
+                        <groupId>com.puppycrawl.tools</groupId>
+                        <artifactId>checkstyle</artifactId>
+                        <version>8.45</version>
+                    </dependency>
+                </dependencies>
                 <configuration>
                     <configLocation>style/checkstyle.xml</configLocation>
                     <encoding>UTF-8</encoding>

diff --git a/style/checkstyle.xml b/style/checkstyle.xml
@@ -12,7 +12,7 @@
     </module>
     <module name="LineLength">
         <property name="max" value="100"/>
-        <property name="ignorePattern" value="^ *\* *[^ ]+$"/>
+        <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://|Reflection\.*"/>
     </module>
     <module name="RegexpSingleline">
         <property name="format" value="System\.out\.println"/>
@@ -76,7 +76,7 @@
         </module>
         <module name="ArrayTypeStyle"/>
         <module name="MethodTypeParameterName">
-            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
+            <property name="format" value="^[A-Z][a-zA-Z0-9]*$"/>
             <message key="name.invalidPattern"
                      value="Method type name ''{0}'' must match pattern ''{1}''."/>
         </module>
@@ -86,7 +86,7 @@
                      value="Method name ''{0}'' must match pattern ''{1}''."/>
         </module>
         <module name="InterfaceTypeParameterName">
-            <property name="format" value="(^[A-Z][0-9]?)$|([A-Z][a-zA-Z0-9]*[T]$)"/>
+            <property name="format" value="^[A-Z][a-zA-Z0-9]*$"/>
             <message key="name.invalidPattern"
                      value="Interface type name ''{0}'' must match pattern ''{1}''."/>
         </module>