more info when marking

apache · Apr 21, 2024 · 9f1f858 · 9f1f858
1 parent 832a9dd
commit 9f1f858
Show file tree

Hide file tree

Showing 13 changed files with 15 additions and 12 deletions.
diff --git a/hugegraph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/Discoverable.java b/hugegraph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/Discoverable.java
@@ -21,7 +21,7 @@
 import org.apache.hugegraph.pd.grpc.discovery.NodeInfos;
 import org.apache.hugegraph.pd.grpc.discovery.Query;
 
-@Useless
+@Useless("discovery related")
 public interface Discoverable {
 
     NodeInfos getNodeInfos(Query query);

diff --git a/hugegraph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/DiscoveryClient.java b/hugegraph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/DiscoveryClient.java
@@ -39,7 +39,7 @@
 import io.grpc.ManagedChannelBuilder;
 import lombok.extern.slf4j.Slf4j;
 
-@Useless
+@Useless("discovery related")
 @Slf4j
 public abstract class DiscoveryClient implements Closeable, Discoverable {
 

diff --git a/...aph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/DiscoveryClientImpl.java b/...aph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/DiscoveryClientImpl.java
@@ -24,7 +24,7 @@
 import org.apache.hugegraph.pd.grpc.discovery.NodeInfo;
 import org.apache.hugegraph.pd.grpc.discovery.RegisterType;
 
-@Useless
+@Useless("discovery related")
 public class DiscoveryClientImpl extends DiscoveryClient {
 
     private final String id;

diff --git a/hugegraph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/LicenseClient.java b/hugegraph-pd/hg-pd-client/src/main/java/org/apache/hugegraph/pd/client/LicenseClient.java
@@ -28,7 +28,7 @@
 import io.grpc.stub.AbstractStub;
 import lombok.extern.slf4j.Slf4j;
 
-@Useless
+@Useless("license related")
 @Slf4j
 public class LicenseClient extends AbstractClient {
 

diff --git a/hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/meta/DiscoveryMetaStore.java b/hugegraph-pd/hg-pd-core/src/main/java/org/apache/hugegraph/pd/meta/DiscoveryMetaStore.java
@@ -23,13 +23,15 @@
 
 import org.apache.commons.lang3.StringUtils;
 import org.apache.hugegraph.pd.common.PDException;
+import org.apache.hugegraph.pd.common.Useless;
 import org.apache.hugegraph.pd.config.PDConfig;
 import org.apache.hugegraph.pd.grpc.discovery.NodeInfo;
 import org.apache.hugegraph.pd.grpc.discovery.NodeInfos;
 import org.apache.hugegraph.pd.grpc.discovery.Query;
 
 import lombok.extern.slf4j.Slf4j;
 
+@Useless("discovery related")
 @Slf4j
 public class DiscoveryMetaStore extends MetadataRocksDBStore {
 

diff --git a/...d/hg-pd-service/src/main/java/org/apache/hugegraph/pd/license/LicenseVerifierService.java b/...d/hg-pd-service/src/main/java/org/apache/hugegraph/pd/license/LicenseVerifierService.java
@@ -1,4 +1,4 @@
-// TODO: uncomment later - maybe useless
+// TODO: uncomment later - maybe useless (license related)
 ///*
 // * Licensed to the Apache Software Foundation (ASF) under one or more
 // * contributor license agreements. See the NOTICE file distributed with this

diff --git a/...-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/license/LicenseVerifyManager.java b/...-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/license/LicenseVerifyManager.java
@@ -1,4 +1,4 @@
-// TODO: uncomment later - maybe useless
+// TODO: uncomment later - maybe useless (license related)
 ///*
 // * Licensed to the Apache Software Foundation (ASF) under one or more
 // * contributor license agreements. See the NOTICE file distributed with this

diff --git a/...raph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/service/DiscoveryService.java b/...raph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/service/DiscoveryService.java
@@ -26,6 +26,7 @@
 import org.apache.hugegraph.pd.RegistryService;
 import org.apache.hugegraph.pd.common.PDException;
 import org.apache.hugegraph.pd.common.PDRuntimeException;
+import org.apache.hugegraph.pd.common.Useless;
 import org.apache.hugegraph.pd.config.PDConfig;
 import org.apache.hugegraph.pd.grpc.Pdpb;
 import org.apache.hugegraph.pd.grpc.discovery.DiscoveryServiceGrpc;
@@ -41,7 +42,7 @@
 import io.grpc.ManagedChannel;
 import lombok.extern.slf4j.Slf4j;
 
-// TODO: uncomment later
+@Useless("discovery related")
 @Slf4j
 @GRpcService
 public class DiscoveryService extends DiscoveryServiceGrpc.DiscoveryServiceImplBase implements

diff --git a/hugegraph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/service/UpgradeService.java b/hugegraph-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/service/UpgradeService.java
@@ -27,7 +27,7 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-@Useless
+@Useless("upgrade related")
 @Slf4j
 public class UpgradeService {
 

diff --git a/...-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/upgrade/VersionScriptFactory.java b/...-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/upgrade/VersionScriptFactory.java
@@ -24,7 +24,7 @@
 import org.apache.hugegraph.pd.upgrade.scripts.PartitionMetaUpgrade;
 import org.apache.hugegraph.pd.upgrade.scripts.TaskCleanUpgrade;
 
-@Useless
+@Useless("upgrade related")
 public class VersionScriptFactory {
 
     private static final List<VersionUpgradeScript> SCRIPTS = new LinkedList<>();

diff --git a/...-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/upgrade/VersionUpgradeScript.java b/...-pd/hg-pd-service/src/main/java/org/apache/hugegraph/pd/upgrade/VersionUpgradeScript.java
@@ -20,7 +20,7 @@
 import org.apache.hugegraph.pd.common.Useless;
 import org.apache.hugegraph.pd.config.PDConfig;
 
-@Useless
+@Useless("upgrade related")
 public interface VersionUpgradeScript {
 
     String UNLIMITED_VERSION = "UNLIMITED_VERSION";

diff --git a/...d-service/src/main/java/org/apache/hugegraph/pd/upgrade/scripts/PartitionMetaUpgrade.java b/...d-service/src/main/java/org/apache/hugegraph/pd/upgrade/scripts/PartitionMetaUpgrade.java
@@ -29,7 +29,7 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-@Useless
+@Useless("upgrade related")
 @Slf4j
 public class PartitionMetaUpgrade implements VersionUpgradeScript {
 

diff --git a/...hg-pd-service/src/main/java/org/apache/hugegraph/pd/upgrade/scripts/TaskCleanUpgrade.java b/...hg-pd-service/src/main/java/org/apache/hugegraph/pd/upgrade/scripts/TaskCleanUpgrade.java
@@ -26,7 +26,7 @@
 
 import lombok.extern.slf4j.Slf4j;
 
-@Useless
+@Useless("upgrade related")
 @Slf4j
 public class TaskCleanUpgrade implements VersionUpgradeScript {
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,7 +27,7 @@ @@
     import lombok.extern.slf4j.Slf4j;
-    @Useless
+    @Useless("upgrade related")
     @Slf4j
     public class UpgradeService {
@@ Expand Down @@