fix(hstore): enable JRaft MaxBodySize config (#2633)

* enable JRaft MaxBodySize config Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'org.apache.hugegraph.store.node.AppConfig$Raft': Unsatisfied dependency expressed through field 'maxBodySize'; nested exception is org.springframework.beans.TypeMismatchException: Failed to convert value of type 'java.lang.String' to required type 'int'; nested exception is java.lang.NumberFormatException: For input string: "512*1024" --------- Co-authored-by: V_Galaxy <[email protected]>
apache · Aug 18, 2024 · 58f58ee · 58f58ee
1 parent ba5b89e
commit 58f58ee
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 3 deletions.
diff --git a/hugegraph-store/hg-store-core/src/main/java/org/apache/hugegraph/store/PartitionEngine.java b/hugegraph-store/hg-store-core/src/main/java/org/apache/hugegraph/store/PartitionEngine.java
@@ -249,6 +249,7 @@ public LogStorage createLogStorage(final String uri, final RaftOptions raftOptio
         raftOptions.setMaxReplicatorInflightMsgs(
                 options.getRaftOptions().getMaxReplicatorInflightMsgs());
         raftOptions.setMaxByteCountPerRpc(1024 * 1024);
+        raftOptions.setMaxBodySize(options.getRaftOptions().getMaxBodySize());
         nodeOptions.setEnableMetrics(true);
 
         final PeerId serverId = JRaftUtils.getPeerId(options.getRaftAddress());

diff --git a/.../hg-store-core/src/main/java/org/apache/hugegraph/store/options/HgStoreEngineOptions.java b/.../hg-store-core/src/main/java/org/apache/hugegraph/store/options/HgStoreEngineOptions.java
@@ -99,6 +99,10 @@ public static class RaftOptions {
          * The maximum number of entries in AppendEntriesRequest
          */
         private int maxEntriesSize = 256;
+        /**
+         * The maximum byte size of AppendEntriesRequest
+         */
+        private int maxBodySize = 512 * 1024;
         /**
          * Raft cluster data backlog occurs, rate limiting wait time in milliseconds.
          **/

diff --git a/hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/AppConfig.java b/hugegraph-store/hg-store-node/src/main/java/org/apache/hugegraph/store/node/AppConfig.java
@@ -172,18 +172,20 @@ public class Raft {
         private int snapshotInterval;
         @Value("${raft.disruptorBufferSize:0}")
         private int disruptorBufferSize;
-        @Value("${raft.max-log-file-size: 50000000000}")
+        @Value("${raft.max-log-file-size:50000000000}")
         private long maxLogFileSize;
-        @Value("${ave-logEntry-size-ratio : 0.95}")
+        @Value("${ave-logEntry-size-ratio:0.95}")
         private double aveLogEntrySizeRation;
-        @Value("${raft.useRocksDBSegmentLogStorage: true}")
+        @Value("${raft.useRocksDBSegmentLogStorage:true}")
         private boolean useRocksDBSegmentLogStorage;
         @Value("${raft.maxSegmentFileSize:67108864}")
         private int maxSegmentFileSize;
         @Value("${raft.maxReplicatorInflightMsgs:256}")
         private int maxReplicatorInflightMsgs;
         @Value("${raft.maxEntriesSize:256}")
         private int maxEntriesSize;
+        @Value("${raft.maxBodySize:524288}")
+        private int maxBodySize;
 
     }
 

diff --git a/.../hg-store-node/src/main/java/org/apache/hugegraph/store/node/grpc/HgStoreNodeService.java b/.../hg-store-node/src/main/java/org/apache/hugegraph/store/node/grpc/HgStoreNodeService.java
@@ -101,6 +101,7 @@ public void init() {
                 setMaxSegmentFileSize(appConfig.getRaft().getMaxSegmentFileSize());
                 setMaxReplicatorInflightMsgs(appConfig.getRaft().getMaxReplicatorInflightMsgs());
                 setMaxEntriesSize(appConfig.getRaft().getMaxEntriesSize());
+                setMaxBodySize(appConfig.getRaft().getMaxBodySize());
             }});
             setFakePdOptions(new FakePdOptions() {{
                 setStoreList(appConfig.getFakePdConfig().getStoreList());